Group aliases diff should be suppressed when only the order is changed#11
Merged
Conversation
SamuZad
approved these changes
Jan 6, 2025
SamuZad
left a comment
SamuZad
left a comment
Owner
There was a problem hiding this comment.
Hi Sebastian, thank you for the contribution!
Yes, this was an oversight on my part
LGTM, will merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
this PR is related to #7 since groups can also have aliases and also might be sorted incorrectly.
After editing I ran
make fmttherefore there are also formatting changes ininternal/provider/resource_dynamic_group.go.Let me know if this can be merged.
Cheers
Sebastian