Skip to content

Bugfix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamUpid wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26fe83e
Bug 2 fixed
SamUpid Oct 9, 2024
1ed1f7e
3rd Fixed
SamUpid Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/main/java/hu/bme/mit/spaceship/TorpedoStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@ public class TorpedoStore {

private int torpedoCount = 0;

private Random generator;

@azmbzrbv azmbzrbv Oct 9, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was good change in the code


public TorpedoStore(int numberOfTorpedos){
this.torpedoCount = numberOfTorpedos;
generator= new Random();

// update failure rate if it was specified in an environment variable
String failureEnv = System.getenv("IVT_RATE");
Expand All @@ -28,20 +31,24 @@ public TorpedoStore(int numberOfTorpedos){
}
}

/**
* @param numberOfTorpedos
* @return
*/
public boolean fire(int numberOfTorpedos){
if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){
new IllegalArgumentException("numberOfTorpedos");
throw new IllegalArgumentException("numberOfTorpedos");

@azmbzrbv azmbzrbv Oct 9, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was good that you noticed this

}

boolean success = false;

// simulate random overheating of the launcher bay which prevents firing
Random generator = new Random();

double r = generator.nextDouble();

if (r >= FAILURE_RATE) {
// successful firing
this.torpedoCount =- numberOfTorpedos;
this.torpedoCount =this.torpedoCount- numberOfTorpedos;
success = true;
} else {
// simulated failure
Expand Down