Skip to content

fix(themes): drop unused legacy landing page template - #1037

Merged
sallainternalbot[bot] merged 3 commits into
masterfrom
bugfix/TD-15098-drop-legacy-landing-page
Aug 19, 2026
Merged

fix(themes): drop unused legacy landing page template#1037
sallainternalbot[bot] merged 3 commits into
masterfrom
bugfix/TD-15098-drop-legacy-landing-page

Conversation

@Ahmed-S-Abduallah

Copy link
Copy Markdown
Contributor

🔍 Problem

Storefront themes still shipped a legacy landing page template even though landing pages now use a dedicated landing-page theme. Usage of the old route is confirmed to be zero.

✅ Changes

  • 🛠️ Remove src/views/pages/landing-page.twig
  • 🎨 Remove landing-page SCSS and its app.scss import
  • 🐛 Drop product-card logic that only applied on the old landing-page slug
  • 🛠️ Four: always initiate the mobile menu (no landing-page exception)
  • 🛠️ Click: keep product-popup trigger on cards (no landing-page exception)

Homepage product sections that use source: landing-page are unchanged.

🧪 Testing

  • Confirm src/views/pages/landing-page.twig is gone
  • Open home/product pages and confirm product cards still render
  • Confirm homepage blocks with source: landing-page still load products
  • Four: confirm the mobile menu still opens
  • Click: confirm product popup still opens from the card

https://salla-dev.atlassian.net/browse/TD-15098

@codacy-production

codacy-production Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0 (≤ 2 duplication)

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@Ahmed-S-Abduallah
Ahmed-S-Abduallah marked this pull request as ready for review August 19, 2026 08:38
@Ahmed-S-Abduallah

Copy link
Copy Markdown
Contributor Author

/merge

@sallainternalbot

Copy link
Copy Markdown
Contributor

⏳ Enqueued for Merge

Your pull request has been added to the merge queue. It will be merged automatically once it reaches the front of the queue ✅


🔄 Queue Status

🚦 Queue

The queue is empty. Good luck!

🧬 PR's Dependencies

├── sallaapp/theme-raed#1037

@sallainternalbot

Copy link
Copy Markdown
Contributor

🔄 Merge In Progress

This pull request has reached the front of the queue and is now being processed for merge.

@sallainternalbot
sallainternalbot Bot merged commit 8e7e6ab into master Aug 19, 2026
1 check passed
@sallainternalbot
sallainternalbot Bot deleted the bugfix/TD-15098-drop-legacy-landing-page branch August 19, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants