Skip to content

feat(catalog): Add barcode to the SKU display setting - #1035

Merged
sallainternalbot[bot] merged 4 commits into
masterfrom
feature/COD-11352-product-show-indetifiers
Aug 23, 2026
Merged

feat(catalog): Add barcode to the SKU display setting#1035
sallainternalbot[bot] merged 4 commits into
masterfrom
feature/COD-11352-product-show-indetifiers

Conversation

@ochanii-salla

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour? (You can also link to the ticket here)

Does this PR introduce a breaking change?

Screenshots (If appropriate)

@ochanii-salla ochanii-salla self-assigned this Aug 17, 2026
@sallainternalbot
sallainternalbot Bot marked this pull request as draft August 17, 2026 10:40
@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@ochanii-salla
ochanii-salla marked this pull request as ready for review August 18, 2026 11:06

@jalmatari jalmatari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should used general translation, not inside the them, please do it on follow-up pr

@jalmatari jalmatari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ochanii-salla

  • make sure to move or re-use the translations from the BE not from iniside the theme translations
  • double check about the FE changes when changing the advance product options, I think it should return also barcode on the price request

@jalmatari

Copy link
Copy Markdown
Member

/merge

@sallainternalbot

Copy link
Copy Markdown
Contributor

⏳ Enqueued for Merge

Your pull request has been added to the merge queue. It will be merged automatically once it reaches the front of the queue ✅


🔄 Queue Status

🚦 Queue

The queue is empty. Good luck!

🧬 PR's Dependencies

├── sallaapp/theme-raed#1035

@sallainternalbot

Copy link
Copy Markdown
Contributor

🔄 Merge In Progress

This pull request has reached the front of the queue and is now being processed for merge.

@sallainternalbot
sallainternalbot Bot merged commit 79b2ec2 into master Aug 23, 2026
1 check passed
@sallainternalbot
sallainternalbot Bot deleted the feature/COD-11352-product-show-indetifiers branch August 23, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants