feat(SHPD-9928): Display bullet-delivery-tag on store header - #1034
Merged
sallainternalbot[bot] merged 7 commits intoAug 19, 2026
Conversation
Mount <salla-quick-delivery-tag> beside the delivery-location (scopes) control
in the top navbar, gated to the homepage via is_page('index'). The component
self-gates on store.settings.quick_delivery_eligible, so it renders only for
eligible stores.
Contributor
Up to standards ✅🟢 Issues
|
…e gate)
The ACs gate the tag on eligibility only (store.settings.quick_delivery_eligible),
not on page; the header is global, so drop the is_page('index') guard and let the
tag render wherever the header shows for eligible stores.
PHPFouda
marked this pull request as ready for review
August 18, 2026 08:01
PHPFouda
approved these changes
Aug 18, 2026
PHPFouda
changed the title
adelelshafey
changed the title
Adds a second lg:hidden instance of salla-bullet-delivery-tag above the top nav for its own full-width row on mobile (Figma 'Mobile version'). The existing inline pill next to scopes is now desktop-only (hidden lg:block). Both self-gate on the same backend flag, so at most one renders at a time.
Matches Figma order — the tag comes before the branch/scope selector in document order, not after.
ashrafreda
approved these changes
Aug 19, 2026
Collaborator
|
/merge |
Contributor
⏳ Enqueued for MergeYour pull request has been added to the merge queue. It will be merged automatically once it reaches the front of the queue ✅ 🔄 Queue Status🚦 QueueThe queue is empty. Good luck! 🧬 PR's Dependencies |
Contributor
🔄 Merge In ProgressThis pull request has reached the front of the queue and is now being processed for merge. |
sallainternalbot
Bot
deleted the
feature/SHPD-9928-display-quick-delivery-tag-on-storefront-homepage
branch
August 19, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mounts
<salla-quick-delivery-tag>in the storefront top navbar, beside the delivery-location (scopes) control — the Quick Delivery homepage tag (توصيل خلال ساعتين / Delivery within 2 hours).How
header.twig(the raed header is composed of direct component tags, not hooks — this matchessalla-localization-modal,salla-search, etc.).{% if is_page('index') %}— the header is global, and the ticket scopes the tag to the homepage.store.settings.quick_delivery_eligible, so it renders only for eligible stores and fails safe to hidden otherwise. Styling ships per-component from twilight (PR #2107) — noapp.csschange.Testing
Depends on
salla-quick-delivery-tagcomponent)Jira: https://salla-dev.atlassian.net/browse/SHPD-9928
screenshot