You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…illed
Add salla-add-product-button validate hook that scrolls to the options
section and shows a soft info hint when optional options are unselected;
checkout is not blocked (required options are validated server-side).
Add optional_options_hint i18n key in Arabic and English.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
…ick buy
- Always call product/options API before quick buy (even on PDP page)
- Priority 1: if offer_options returned (Y has required options) → open modal
showing Y's thumbnail + name + options as steps
- Priority 2: if X itself has free options → PDP: validate in-place,
non-PDP: open modal for X
- _pendingOfferFreeOptions injected as free_product_options[Y.id] in
cart::before.add.item so backend receives Y's selections alongside X
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…k checkout
- Fix API key: read advance_free_product (array) instead of offer_options
- Replace single-offer handler with _handleOfferFreeOptionsSteps that loops
each entry sequentially, opening one salla-order-options-modal per Y
- Pending offer options stored as [{productId, options}] array instead of
single object
- Cart injection promotes X to products[0] and appends each Y as products[N]
with bracket-notation keys so MiniCheckoutRequest parses them correctly
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… DOM
The modal is injected by salla-add-product-button at runtime, so
querySelector returns null when our hook fires. Create and attach it
ourselves, then await customElements.whenDefined() before calling open().
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The storefront gate now lives in Twilight, so every theme gets it rather than Raed alone. That matters because the server-side check in MiniCheckoutRequest applies to all themes — a merchant on any other theme would otherwise hit a validation error with no UI to satisfy it.
The Twilight branch already carried the wizard, product card, offer badge and RTL work (af744d5b7..5923a7594), so this behaviour was effectively moved out of the theme on 2026-08-08..10 and this PR is the earlier attempt at the same thing.
Shipping both would mean two gates on one storefront, each with its own cart::before.add.item handler rewriting the same payload.
One thing deliberately not carried over: pages.products.optional_options_hint (the nudge when optional options are left blank) has no Twilight equivalent. It never fired in practice — _handlePdpFreeOptions reads optionsEl.optionsData, a private Stencil @State that isn't readable from the host element — but if that nudge is wanted as a feature, it belongs in salla-product-options and is worth its own ticket. required_free_options_message is covered: the modal reports required-option failures via blocks.order_options.required_message, and PDP validation goes through validateAndScroll().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.