Skip to content

feat(themes): channel visibility for home blocks - #1019

Merged
sallainternalbot[bot] merged 15 commits into
masterfrom
feature/TD-13969-channel-visibility
Aug 26, 2026
Merged

feat(themes): channel visibility for home blocks#1019
sallainternalbot[bot] merged 15 commits into
masterfrom
feature/TD-13969-channel-visibility

Conversation

@eslamoo

@eslamoo eslamoo commented Aug 3, 2026

Copy link
Copy Markdown
Member

What

Gives the backend a stable per-component hook on every home block root, so it can hide a block on Desktop web or Mobile web by injecting CSS into the document head.

Every home block root <section> now carries component-id="{{ componentId }}". The theme emits no visibility logic and no classes of its own.

<section component-id="{{ componentId }}" data-testid="store-home-brands" class="s-block ...">

@sallainternalbot
sallainternalbot Bot marked this pull request as draft August 3, 2026 22:19
@codacy-production

codacy-production Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0 (≤ 2 duplication)

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@bakrimoharram
bakrimoharram force-pushed the feature/TD-13969-channel-visibility branch from ddf9d6d to 8eb2e89 Compare August 6, 2026 08:15
@bakrimoharram

Copy link
Copy Markdown
Contributor

@greptile-apps review

@eslamoo
eslamoo marked this pull request as ready for review August 24, 2026 08:39
@eslamoo

eslamoo commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

/autoupdate

@sallainternalbot

Copy link
Copy Markdown
Contributor

Auto Update Summary

Updated PRs:

Already Synced PRs:

… classes

Backend now injects the per-channel display rules into the document head,
keyed by [component-id="..."], so the theme no longer needs to read
channel_visibility or ship the s-hide-on-* utilities.

Drops 05-utilities/channel-visibility.scss and its app.scss registration,
and replaces the inline ternaries on all 19 home block roots with a single
component-id attribute.
@eslamoo

eslamoo commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

/autoupdate

@sallainternalbot

Copy link
Copy Markdown
Contributor

Auto Update Summary

Already Synced PRs:

@eslamoo

eslamoo commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

/merge

@sallainternalbot

Copy link
Copy Markdown
Contributor

⏳ Enqueued for Merge

Your pull request has been added to the merge queue. It will be merged automatically once it reaches the front of the queue ✅


🔄 Queue Status

🚦 Queue

The queue is empty. Good luck!

🧬 PR's Dependencies

├── sallaapp/theme-raed#1019

@sallainternalbot

Copy link
Copy Markdown
Contributor

🔄 Merge In Progress

This pull request has reached the front of the queue and is now being processed for merge.

@sallainternalbot
sallainternalbot Bot merged commit ae0bb10 into master Aug 26, 2026
1 check passed
@sallainternalbot
sallainternalbot Bot deleted the feature/TD-13969-channel-visibility branch August 26, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants