revert(CPD-31586): chillerlan/php-qrcode back to v4 - #71
Merged
Conversation
Reverts the v4 -> v5 upgrade released in 3.0.5. Restores the `^4.3` constraint and the plain QROptions render path, dropping the GDIMAGE_PNG/imageTransparent defaults that only exist in v5. The explicit `?string $file` nullable type is kept, since it is independent of the qrcode major version and avoids a PHP 8.4+ deprecation notice. Reverts a296af9 (#65)
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | ✅ 0 (≤ 2 duplication) |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the v4 -> v5 upgrade released in 3.0.5. Restores the
^4.3constraint and the plain QROptions render path, dropping the GDIMAGE_PNG/imageTransparent defaults that only exist in v5.The explicit
?string $filenullable type is kept, since it is independent of the qrcode major version and avoids a PHP 8.4+ deprecation notice.Reverts a296af9 (#65)
Greptile Summary
Reverts
chillerlan/php-qrcodefrom v5 to v4 and restores the plain v4QROptionsrendering path while retaining the nullable file parameter.^5.0to^4.3.Confidence Score: 4/5
The undeclared GD dependency should be fixed before merging because supported installations can otherwise fail on the documented default QR-rendering path.
The downgrade restores a GD-backed default renderer, while Composer permits installation without GD and the public render API invokes that renderer without selecting a non-GD alternative.
Files Needing Attention: composer.json
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "revert(CPD-31586): `chillerlan/php-qrcod..." | Re-trigger Greptile