馃И Add test for VAL-SYN-007 (Duplicate Definitions) - #29
Conversation
- Added `tests/test_validation_syn_007.py` to cover duplicate definitions across synsets. - Includes positive test case (detection), negative test case (clean data), and filtered test case (scoped validation). - Refactored imports in `src/wordnet_editor/importer.py` to fix `ModuleNotFoundError` during testing.
|
馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR introduces a new test file
tests/test_validation_syn_007.pyto verify the functionality of theVAL-SYN-007validation rule, which detects duplicate definitions across synsets. The test suite includes cases for detecting duplicates, verifying clean data, and checking scoped validation (filtering by lexicon ID). Additionally,src/wordnet_editor/importer.pywas updated to movewnimports to the top level, resolvingModuleNotFoundErrorissues encountered during the test run.Coverage
VAL-SYN-007is raised with the correct count.lexicon_idfilter, counting duplicates only within the specified scope.Result
VAL-SYN-007correctly identifies duplicates.PR created automatically by Jules for task 13102920572237085417 started by @Salah-Sal