refactor(templates): centralize ownership map

Author: ymkiux

plugins/prompt-templates/comment-polish/index.mjs

@@ -1,9 +1,12 @@
-import { commentPolishOwnership } from './ownership.mjs';
+import { templateOwnershipById } from '../ownership.mjs';
 
 export function buildBuiltinCommentPolishTemplate(t) {
     const tr = (key, fallback, params = null) => (typeof t === 'function' ? t(key, params) : fallback);
     const line1 = tr('plugins.builtin.commentPolish.line1', '轻微收敛以下代码注释');
     const timestamp = new Date().toISOString();
+    const ownership = templateOwnershipById && templateOwnershipById.builtin_comment_polish
+        ? templateOwnershipById.builtin_comment_polish
+        : null;
     return {
         id: 'builtin_comment_polish',
         name: tr('plugins.builtin.commentPolish.name', '代码注释润色'),
@@ -16,7 +19,7 @@ export function buildBuiltinCommentPolishTemplate(t) {
         createdAt: timestamp,
         updatedAt: timestamp,
         isBuiltin: true,
-        createdBy: commentPolishOwnership.createdBy,
-        maintainers: commentPolishOwnership.maintainers
+        createdBy: ownership && typeof ownership.createdBy === 'string' ? ownership.createdBy : '',
+        maintainers: ownership && Array.isArray(ownership.maintainers) ? ownership.maintainers : []
     };
 }

plugins/prompt-templates/comment-polish/ownership.mjs

@@ -1,4 +1,4 @@
-import { pluginOwnership } from './plugin-ownership.mjs';
+import { pluginOwnership } from './ownership.mjs';
 
 const baseMeta = {
     id: 'prompt-templates',

plugins/prompt-templates/manifest.mjs

@@ -0,0 +1,19 @@
+export const pluginOwnership = {
+    pluginId: 'prompt-templates',
+    createdBy: 'ymkiux',
+    maintainers: ['ymkiux']
+};
+
+export const templateOwnershipById = {
+    builtin_comment_polish: {
+        templateId: 'builtin_comment_polish',
+        createdBy: 'ymkiux',
+        maintainers: ['ymkiux']
+    },
+    builtin_rule_ack: {
+        templateId: 'builtin_rule_ack',
+        createdBy: 'ymkiux',
+        maintainers: ['ymkiux']
+    }
+};
+

plugins/prompt-templates/ownership.mjs

@@ -1,9 +1,12 @@
-import { ruleAckOwnership } from './ownership.mjs';
+import { templateOwnershipById } from '../ownership.mjs';
 
 export function buildBuiltinRuleAckTemplate(t) {
     const tr = (key, fallback, params = null) => (typeof t === 'function' ? t(key, params) : fallback);
     const line1 = tr('plugins.builtin.ruleAck.line1', '请根据【{{rule}}】，收到请回复');
     const timestamp = new Date().toISOString();
+    const ownership = templateOwnershipById && templateOwnershipById.builtin_rule_ack
+        ? templateOwnershipById.builtin_rule_ack
+        : null;
     return {
         id: 'builtin_rule_ack',
         name: tr('plugins.builtin.ruleAck.name', '规则确认回复'),
@@ -12,7 +15,7 @@ export function buildBuiltinRuleAckTemplate(t) {
         createdAt: timestamp,
         updatedAt: timestamp,
         isBuiltin: true,
-        createdBy: ruleAckOwnership.createdBy,
-        maintainers: ruleAckOwnership.maintainers
+        createdBy: ownership && typeof ownership.createdBy === 'string' ? ownership.createdBy : '',
+        maintainers: ownership && Array.isArray(ownership.maintainers) ? ownership.maintainers : []
     };
 }

plugins/prompt-templates/plugin-ownership.mjs

@@ -28,13 +28,14 @@ test('each builtin plugin has ownership file matched to plugin id', async () =>
     assert.ok(folders.length > 0, 'expected at least one builtin plugin folder');
 
     for (const folder of folders) {
-        const ownershipPath = path.join(pluginsDir, folder, 'plugin-ownership.mjs');
-        assert.ok(fs.existsSync(ownershipPath), `missing plugin-ownership.mjs for plugin: ${folder}`);
+        const ownershipPath = path.join(pluginsDir, folder, 'ownership.mjs');
+        assert.ok(fs.existsSync(ownershipPath), `missing ownership.mjs for plugin: ${folder}`);
 
         const manifestUrl = pathToFileURL(path.join(pluginsDir, folder, 'manifest.mjs')).href;
         const ownershipUrl = pathToFileURL(ownershipPath).href;
         const { pluginMeta } = await import(`${manifestUrl}?t=${Date.now()}`);
-        const { pluginOwnership } = await import(`${ownershipUrl}?t=${Date.now()}`);
+        const mod = await import(`${ownershipUrl}?t=${Date.now()}`);
+        const pluginOwnership = mod && mod.pluginOwnership ? mod.pluginOwnership : null;
 
         assert.ok(pluginMeta && typeof pluginMeta === 'object', `invalid pluginMeta for plugin: ${folder}`);
         assert.strictEqual(pluginMeta.id, folder, `pluginMeta.id must match folder name: ${folder}`);

plugins/prompt-templates/rule-ack/index.mjs

@@ -21,11 +21,14 @@ test('prompt template ownership is bound to builtin template id', async () => {
         }
     ];
 
+    const ownershipUrl = pathToFileURL(path.join(pluginRoot, 'ownership.mjs')).href;
+    const ownershipMod = await import(`${ownershipUrl}?t=${Date.now()}`);
+    const templateOwnershipById = ownershipMod && ownershipMod.templateOwnershipById ? ownershipMod.templateOwnershipById : null;
+    assert.ok(templateOwnershipById && typeof templateOwnershipById === 'object');
+
     for (const tpl of templates) {
         const buildUrl = pathToFileURL(path.join(pluginRoot, tpl.folder, 'index.mjs')).href;
-        const ownershipUrl = pathToFileURL(path.join(pluginRoot, tpl.folder, 'ownership.mjs')).href;
-        const ownershipMod = await import(`${ownershipUrl}?t=${Date.now()}`);
-        const ownership = tpl.folder === 'comment-polish' ? ownershipMod.commentPolishOwnership : ownershipMod.ruleAckOwnership;
+        const ownership = templateOwnershipById[tpl.expectedId] || null;
         assert.ok(ownership && typeof ownership === 'object');
         assert.strictEqual(ownership.templateId, tpl.expectedId);
         assert.ok(typeof ownership.createdBy === 'string' && ownership.createdBy.trim());