chore(templates): bind ownership to template id

Author: ymkiux

plugins/prompt-templates/comment-polish/index.mjs

@@ -1,4 +1,4 @@
-import { pluginOwnership } from '../ownership.mjs';
+import { commentPolishOwnership } from './ownership.mjs';
 
 export function buildBuiltinCommentPolishTemplate(t) {
     const tr = (key, fallback, params = null) => (typeof t === 'function' ? t(key, params) : fallback);
@@ -16,7 +16,7 @@ export function buildBuiltinCommentPolishTemplate(t) {
         createdAt: timestamp,
         updatedAt: timestamp,
         isBuiltin: true,
-        createdBy: pluginOwnership.createdBy,
-        maintainers: pluginOwnership.maintainers
+        createdBy: commentPolishOwnership.createdBy,
+        maintainers: commentPolishOwnership.maintainers
     };
 }

plugins/prompt-templates/comment-polish/ownership.mjs

@@ -0,0 +1,5 @@
+export const commentPolishOwnership = {
+    templateId: 'builtin_comment_polish',
+    createdBy: 'ymkiux',
+    maintainers: ['ymkiux']
+};

plugins/prompt-templates/manifest.mjs

@@ -1,4 +1,4 @@
-import { pluginOwnership } from './ownership.mjs';
+import { pluginOwnership } from './plugin-ownership.mjs';
 
 const baseMeta = {
     id: 'prompt-templates',

plugins/prompt-templates/ownership.mjs …ns/prompt-templates/plugin-ownership.mjsplugins/prompt-templates/ownership.mjs renamed to plugins/prompt-templates/plugin-ownership.mjs plugins/prompt-templates/ownership.mjs renamed to plugins/prompt-templates/plugin-ownership.mjs

@@ -3,3 +3,4 @@ export const pluginOwnership = {
     createdBy: 'ymkiux',
     maintainers: ['ymkiux']
 };
+

plugins/prompt-templates/rule-ack/index.mjs

@@ -1,4 +1,4 @@
-import { pluginOwnership } from '../ownership.mjs';
+import { ruleAckOwnership } from './ownership.mjs';
 
 export function buildBuiltinRuleAckTemplate(t) {
     const tr = (key, fallback, params = null) => (typeof t === 'function' ? t(key, params) : fallback);
@@ -12,7 +12,7 @@ export function buildBuiltinRuleAckTemplate(t) {
         createdAt: timestamp,
         updatedAt: timestamp,
         isBuiltin: true,
-        createdBy: pluginOwnership.createdBy,
-        maintainers: pluginOwnership.maintainers
+        createdBy: ruleAckOwnership.createdBy,
+        maintainers: ruleAckOwnership.maintainers
     };
 }

plugins/prompt-templates/rule-ack/ownership.mjs

@@ -0,0 +1,5 @@
+export const ruleAckOwnership = {
+    templateId: 'builtin_rule_ack',
+    createdBy: 'ymkiux',
+    maintainers: ['ymkiux']
+};

tests/unit/plugins-ownership-contract.test.mjs

@@ -28,8 +28,8 @@ test('each builtin plugin has ownership file matched to plugin id', async () =>
     assert.ok(folders.length > 0, 'expected at least one builtin plugin folder');
 
     for (const folder of folders) {
-        const ownershipPath = path.join(pluginsDir, folder, 'ownership.mjs');
-        assert.ok(fs.existsSync(ownershipPath), `missing ownership.mjs for plugin: ${folder}`);
+        const ownershipPath = path.join(pluginsDir, folder, 'plugin-ownership.mjs');
+        assert.ok(fs.existsSync(ownershipPath), `missing plugin-ownership.mjs for plugin: ${folder}`);
 
         const manifestUrl = pathToFileURL(path.join(pluginsDir, folder, 'manifest.mjs')).href;
         const ownershipUrl = pathToFileURL(ownershipPath).href;
@@ -47,4 +47,3 @@ test('each builtin plugin has ownership file matched to plugin id', async () =>
         }
     }
 });
-

tests/unit/prompt-templates-ownership-contract.test.mjs

@@ -0,0 +1,40 @@
+import assert from 'assert';
+import { pathToFileURL } from 'url';
+import path from 'path';
+import { fileURLToPath } from 'url';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const root = path.join(__dirname, '..', '..');
+
+const pluginRoot = path.join(root, 'plugins', 'prompt-templates');
+
+test('prompt template ownership is bound to builtin template id', async () => {
+    const templates = [
+        {
+            folder: 'comment-polish',
+            expectedId: 'builtin_comment_polish'
+        },
+        {
+            folder: 'rule-ack',
+            expectedId: 'builtin_rule_ack'
+        }
+    ];
+
+    for (const tpl of templates) {
+        const buildUrl = pathToFileURL(path.join(pluginRoot, tpl.folder, 'index.mjs')).href;
+        const ownershipUrl = pathToFileURL(path.join(pluginRoot, tpl.folder, 'ownership.mjs')).href;
+        const ownershipMod = await import(`${ownershipUrl}?t=${Date.now()}`);
+        const ownership = tpl.folder === 'comment-polish' ? ownershipMod.commentPolishOwnership : ownershipMod.ruleAckOwnership;
+        assert.ok(ownership && typeof ownership === 'object');
+        assert.strictEqual(ownership.templateId, tpl.expectedId);
+        assert.ok(typeof ownership.createdBy === 'string' && ownership.createdBy.trim());
+        assert.ok(Array.isArray(ownership.maintainers) && ownership.maintainers.length > 0);
+
+        const mod = await import(`${buildUrl}?t=${Date.now()}`);
+        const buildFn = tpl.folder === 'comment-polish' ? mod.buildBuiltinCommentPolishTemplate : mod.buildBuiltinRuleAckTemplate;
+        const built = buildFn(null);
+        assert.strictEqual(built.id, tpl.expectedId);
+        assert.strictEqual(built.createdBy, ownership.createdBy);
+    }
+});