First commit for Panaroo tool#1
Open
FMG0411 wants to merge 17 commits into
Open
Conversation
SaimMomin12
reviewed
Nov 4, 2024
SaimMomin12
requested changes
Nov 7, 2024
SaimMomin12
left a comment
SaimMomin12
left a comment
Owner
There was a problem hiding this comment.
Hi @FMG0411
I have added some comments and suugestion in line. Please work on them and update the Pull request. I will review again.
SaimMomin12
requested changes
Nov 12, 2024
SaimMomin12
left a comment
SaimMomin12
left a comment
Owner
There was a problem hiding this comment.
Hi @FMG0411
I think, it would be a wise decision to reduce the tool arguments and only keep that are essential. Additionally, it would be nice to group them based on sections. Such as (Mode, Matching, Refind, Graph Correction, Gene Alignment)
We also need to extend the test case more.
SaimMomin12
reviewed
Nov 12, 2024
SaimMomin12
requested changes
Nov 12, 2024
SaimMomin12
reviewed
Nov 13, 2024
SaimMomin12
requested changes
Nov 19, 2024
SaimMomin12
left a comment
SaimMomin12
left a comment
Owner
There was a problem hiding this comment.
Overall looks good, please look at the some of the suggestion that I have made in this PR.
Major things:
- Add missing output files
- Add parameters for Graph correction and Gene alignment sections
After all the above suggestions, you should have some test passing. If not, we can have a look.
SaimMomin12
reviewed
Nov 20, 2024
SaimMomin12
pushed a commit
that referenced
this pull request
May 14, 2025
…-example-image-fix Added missing files to the image folder of GraphicsMagick tool
SaimMomin12
pushed a commit
that referenced
this pull request
Jun 20, 2025
Update of your sylph wrapper
SaimMomin12
pushed a commit
that referenced
this pull request
Nov 10, 2025
[WIP] Remove 3dt_tile_merge file from default branch
SaimMomin12
pushed a commit
that referenced
this pull request
Nov 10, 2025
Add 3Dtrees: Tile & Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.