chore: type product detail loader result - #42
Merged
github-actions[bot] merged 1 commit intoJun 7, 2026
Conversation
Co-authored-by: Sahar <SaharPak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProductPageDatareturn type to the product detail loader.ProductWithCountscast by narrowing the typed loader result afternotFound().Why it matters
This keeps the product detail page's data contract clearer and lets TypeScript validate usage closer to where the data is loaded.
Validation
npx eslint src/app/p/[id]/page.tsxnpx tsc --project tsconfig.changed-file.json --pretty false(temporary config limited to the changed page; removed afterward)Note:
npm run buildcompiled successfully but failed during TypeScript because the existingopen-next.config.tsimports@opennextjs/cloudflare, which is not installed from the current package manifest.