Skip to content

chore: type comment author shape #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Jun 4, 2026
Merged

chore: type comment author shape #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/components/comment-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,7 @@ export function CommentSection({ productId, mockComments }: Props) {

<div className="mt-4 space-y-4">
{comments.map((comment) => {
const author = comment.author as unknown as {
display_name: string;
handle: string | null;
avatar_url: string | null;
};
const author = comment.author;
return (
<div key={comment.id} className="rounded-xl border border-border bg-card-bg p-4">
<div className="flex items-center gap-2">
Expand Down
3 changes: 2 additions & 1 deletion src/types/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export interface Product {
}

export type ProductBuilder = Pick<Profile, "display_name" | "handle" | "avatar_url">;
export type CommentAuthor = Pick<Profile, "display_name" | "handle" | "avatar_url">;

export interface ProductWithCounts extends Product {
vote_count: number;
Expand All @@ -57,7 +58,7 @@ export interface Comment {
body: string;
status: CommentStatus;
created_at: string;
author?: Pick<Profile, "display_name" | "handle" | "avatar_url">;
author?: CommentAuthor;
}

export interface DemoDay {
Expand Down