fix: respect explicit config.head_dim in cnets attention#342
Open
AchuthReddy-16 wants to merge 1 commit into
Open
fix: respect explicit config.head_dim in cnets attention#342AchuthReddy-16 wants to merge 1 commit into
AchuthReddy-16 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315
Credit to @gcy-hw95, who diagnosed this and tested the fix in #315 — this PR just submits it properly since it never got merged.
This PR fixes the
head_dimhandling ineagle/model/cnets.py.Previously,
LlamaAttentionalways computed:That works for standard Llama-style configs, but it does not hold for some Qwen3 configs where
head_dimis explicitly defined. For example, Qwen3-4B hashidden_size=2560andnum_attention_heads=32, which gives80using the old formula, but the actualhead_dimis128.Because of this mismatch, loading Qwen3 checkpoints can fail with shape mismatch errors.
This PR changes the code to:
config.head_dimwhen it existshidden_size // num_headswhenconfig.head_dimis not presenthidden_size == num_heads * head_dimnum_heads * head_diminstead of assuming it is equal tohidden_sizeThis follows the same general pattern already used in
modeling_qwen3_kv.py.One note: I left the
pretraining_tp > 1path unchanged because it seems separate from this issue and was not part of the original fix discussed in #315.