infra-bin-releases: make build.sh idempotent (mkdir -p go) - #175
Open
Montana wants to merge 1 commit into
Open
Conversation
Change `mkdir go` to `mkdir -p go` in `infra-bin-releases/build.sh`.
The script runs under `set -e`. `mkdir go` (without `-p`) exits non-zero if `go/` already exists, which happens on any re-run or whenever the workspace isn't pristine, and `set -e` then aborts the entire build.
The very next `mkdir` in the same script (line 11, `mkdir -p go/src/${VENDORDIR}`) already uses `-p`, so this just makes the two consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
mkdir gotomkdir -p goininfra-bin-releases/build.sh.The script runs under
set -e.mkdir go(without-p) exits non-zero ifgo/already exists, which happens on any re-run or whenever the workspace isn't pristine, andset -ethen aborts the entire build.The very next
mkdirin the same script (line 11,mkdir -p go/src/${VENDORDIR}) already uses-p, so this just makes the two consistent.