fix: restore 'all 97 bindings' claim dropped by README rewrite - #12
Closed
fuleinist wants to merge 1 commit into
Closed
fix: restore 'all 97 bindings' claim dropped by README rewrite#12fuleinist wants to merge 1 commit into
fuleinist wants to merge 1 commit into
Conversation
Commit 4a610f1 ('Add beginner onboarding guidance') rewrote README.md and removed the 'all 97 bindings' phrase from the shortcuts row, which breaks documentation.test.mjs's forward CLAIMS sweep: FAIL README.md says 'all 97 bindings' The CLAIMS table in docfacts.mjs declares: ['README.md', 'bindings', (n) => `all ${n} bindings`] Restore the claim so the documentation test passes again. The count (97) matches Object.keys(DEFAULT_KEYS).length in bindings.ts. Fixes SYKhayyat#10
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit 4a610f1 ('Add beginner onboarding guidance') rewrote
README.mdand removed theall 97 bindingsphrase from the shortcuts row in the 'Where to go' table. This breaksdocumentation.test.mjs's forward CLAIMS sweep, which declares:The suite fails on:
(See CI run: https://github.com/SYKhayyat/ksav/actions/runs/33024821831 —
106 files · 7564 passed, 1 failed.)Fix
Restore the binding-count claim on the shortcuts row, matching the pre-rewrite phrasing. The count 97 matches
Object.keys(DEFAULT_KEYS).lengthinksav/app/src/bindings.ts(lines 28–364, 97 key-value entries).The parallel claim in
docs/start-here.mdwas not touched by the rewrite and still reads correctly (all 97 bindings).Verification
grep -cE '^\s+\S+:\s*"' ksav/app/src/bindings.tsbetween theDEFAULT_KEYSbraces → 97.grep 'all.*bindings' README.md docs/start-here.mdnow returnsall 97 bindingson both pages, matching whatdocfacts.mjsexpects.Fixes #10.