Skip to content

fix: restore 'all 97 bindings' claim dropped by README rewrite - #12

Closed
fuleinist wants to merge 1 commit into
SYKhayyat:mainfrom
fuleinist:fix/restore-bindings-count-claim
Closed

fix: restore 'all 97 bindings' claim dropped by README rewrite#12
fuleinist wants to merge 1 commit into
SYKhayyat:mainfrom
fuleinist:fix/restore-bindings-count-claim

Conversation

@fuleinist

Copy link
Copy Markdown

Summary

Commit 4a610f1 ('Add beginner onboarding guidance') rewrote README.md and removed the all 97 bindings phrase from the shortcuts row in the 'Where to go' table. This breaks documentation.test.mjs's forward CLAIMS sweep, which declares:

['README.md', 'bindings', (n) => `all ${n} bindings`]

The suite fails on:

FAIL README.md says 'all 97 bindings'
  got false, wanted something truthy

(See CI run: https://github.com/SYKhayyat/ksav/actions/runs/33024821831106 files · 7564 passed, 1 failed.)

Fix

Restore the binding-count claim on the shortcuts row, matching the pre-rewrite phrasing. The count 97 matches Object.keys(DEFAULT_KEYS).length in ksav/app/src/bindings.ts (lines 28–364, 97 key-value entries).

-| **learn the keyboard** | [`docs/shortcuts.md`](docs/shortcuts.md) |
+| **learn the keyboard** | [`docs/shortcuts.md`](docs/shortcuts.md) — all 97 bindings in both languages, generated from the source |

The parallel claim in docs/start-here.md was not touched by the rewrite and still reads correctly (all 97 bindings).

Verification

  • grep -cE '^\s+\S+:\s*"' ksav/app/src/bindings.ts between the DEFAULT_KEYS braces → 97.
  • grep 'all.*bindings' README.md docs/start-here.md now returns all 97 bindings on both pages, matching what docfacts.mjs expects.
  • The documentation-test fence is declarative over markdown, so CI green follows from the regex match.

Fixes #10.

Commit 4a610f1 ('Add beginner onboarding guidance') rewrote README.md
and removed the 'all 97 bindings' phrase from the shortcuts row, which
breaks documentation.test.mjs's forward CLAIMS sweep:

  FAIL README.md says 'all 97 bindings'

The CLAIMS table in docfacts.mjs declares:
  ['README.md', 'bindings', (n) => `all ${n} bindings`]

Restore the claim so the documentation test passes again. The count
(97) matches Object.keys(DEFAULT_KEYS).length in bindings.ts.

Fixes SYKhayyat#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README rewrite in 13eb66d broke the binding count assertion in documentation.test.mjs

1 participant