69 need to integrate corridorsshcq data - #72
Open
mikedurand wants to merge 22 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has my latest changes to fix the computeFLP functions. Instead of using the steady flow conserved map at low flow (33rd percentile) it just rescales the FLPE Q to the integrated (basin scale) mean flow. Works for all algos in principle, but so far only tested on metroman, sic4dvar, and momma, for the Noatak domain.
This also includes support for CORRIDORS, and has tested and run on the Noatak, but so far only has the Noatak CORRIDORS file. I have only tested this with my own run-confluence-offline branch, so the expected behavior to ignore CORRIDORS gracefully when run without CORRIDORS arguments has not yet been tested, but should work.