[feat] 로깅 1차 구현 - #83
Open
Gobans wants to merge 12 commits into
Open
Conversation
acious
reviewed
Oct 3, 2023
| private let injector: Injector | ||
| @ObservedObject private var coordinator: Coordinator | ||
| @ObservedObject private var toastHelper: ToastHelper | ||
| private let logger: SWMLogger |
acious
reviewed
Oct 3, 2023
Comment on lines
+33
to
+37
| public init(userId: Int? = nil, gender: String? = nil, age: Int? = nil) { | ||
| self.userId = userId | ||
| self.gender = gender | ||
| self.age = age | ||
| } |
Contributor
There was a problem hiding this comment.
Builder쪽에는 init 메소드가 필요없지 않을까요?
acious
reviewed
Oct 3, 2023
| public func setAge(age: Int) -> Builder { | ||
| self.age = age | ||
| return self | ||
| } |
acious
reviewed
Oct 3, 2023
Comment on lines
+51
to
+55
| let loggingAPI = LoggingAPI( | ||
| serverUrl: serverUrl, | ||
| serverPath: serverPath, | ||
| authorization: authorization, | ||
| scheme: scheme) |
Contributor
There was a problem hiding this comment.
LoggingAPI객체를 하나를 만들고 각 logging마다 scheme만 갈아끼우는 방식으로 매번 메모리를 할당하는 것이 아닌 한번 만들어진 LoggingAPI인스턴스만 재활용해서 쓰는게 좋을거같아요.
acious
reviewed
Oct 3, 2023
| private let moyaProvider = MoyaProvider<LoggingAPI>() | ||
| private var cancelBag = Set<AnyCancellable>() | ||
|
|
||
| public init(serverUrl: String, serverPath: String, OSNameAndVersion: String) { |
Contributor
There was a problem hiding this comment.
여기에 앱 실행타임에 UUID / AppVersion도 넣어서 OSNameAndVersion과 같은 MadatoryProperty도 넣어줄수 있을까요?
ddophi98
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업내용