Add packaging mechanism to automatically build SV-Comp zip#30
Draft
nils-loose wants to merge 13 commits into
Draft
Add packaging mechanism to automatically build SV-Comp zip#30nils-loose wants to merge 13 commits into
zip#30nils-loose wants to merge 13 commits into
Conversation
The executor no longer writes stats_<id>.json. Instead it accumulates missing invocations (each flagged when it caused symbolic context loss) in StatsStorage and ships them with the trace (TraceDTO.missingInvocations / new InvocationDTO). The explorer accumulates this per testcase on the Tree and, at testcase completion, writes a single consolidated stats.json to the log dir — mirroring the existing timing_data.json write. It holds the verdict, soundness flags, the missing-invocation superset and the explicit context-loss subset, so the analysis can rely on authoritative structured data instead of scraping logs. Execution errors cannot ride the trace: in sv-comp every error path halts the JVM before the trace is sent. They are instead surfaced from the executor stdout markers the explorer already scans in determine_next_step ([SWAT Exception] / internal SWAT AssertionError), recorded on the Tree and included in stats.json. Removes the now-dead executor error chain (StatsStorage.errors, ThreadContext/ThreadHandler.recordException, ErrorRecord) and the unused StatsStorage.entrypoint. Part of #25. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…idation Implements the remaining issue #25 parts in the svcomp CLI (lib/ + commands/): - Run folder structure: each `svcomp test run` writes its per-testcase logs and aggregated results under one timestamped runs/run_<ts>/{logs,results} dir (runs-debug/<target>/run_<ts>/logs for debug configs). Previous runs are kept; a single run timestamp is threaded through command generation and result writing. - Analysis on stats.json: rewrote lib/analysis/context_loss.py to read each testcase's consolidated stats.json instead of scraping explorer.log / stats_*.json. It pairs a run's results with its logs and reports the missing-invocation superset and its authoritative context-loss subset, fixing the old regex inconsistency. - Scoring summary: `svcomp analyze results` prints a Correct/Failed/Unk/Error/Timeout table per category and overall. - Consolidation: run_locally.sh and ci_run.sh now invoke `./svcomp test run`; the dead legacy top-level duplicates are removed (target_execution.py, command_generation.py, analyse_ctx_loss.py, analyze_by_correctness.py, compare_results.py, target_selection.py, witness_validation.py, util.py, dtypes.py). README and .gitignore updated. Closes #25. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SWAT's internal time cutoffs pre-empt it well before benchexec's competition limit (15 min): - run_swat.py hard-killed the symbolic-execution run at 180s (the default run_command_with_timeout). Default is now None (no internal cutoff); benchexec enforces the wall/CPU limit externally. - the SV-COMP exploration's Z3 solves were capped at 60s. Removed, but ONLY for the sv-comp path: Z3Handler.solve / StrategyService.solve_branch now take a timeout (default 60s, unchanged for passive/http/target/simple drivers), and SVCompDriver / SVCompHandler pass None. solve_with_optimization is left as-is (it is not on the sv-comp solve_branch path). Net: SWAT explores with the full SV-COMP budget; other modes keep their 60s solver timeout. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The old version mistakenly modified the 'this' Object, causing unexpected behaviour.
nils-loose
commented
Jun 29, 2026
Comment on lines
+9
to
+10
| SVCOMP_REFERENCE_URL: https://zenodo.org/api/records/17748741/files/swat-verify.zip/content | ||
| SVCOMP_REFERENCE_MD5: 8c776d19ac33ecf5c1c7441d16cc18a6 |
Contributor
Author
There was a problem hiding this comment.
@k0lja Can you propose a different mechanism, perhaps another repository here that publishes the required files, I dont want to reference zenodo here in the CI
Contributor
Author
There was a problem hiding this comment.
In addition, the venv we are using is built on the specific ubuntu version required by sv-comp. updating the dependencies is a hassle atm. Can you check if it could be possible either here or in the supporting repo (for the above) you can actually build the venv based on the requirements (pip freeze the current venv) as part of the ci there? this would make updating the venv much easier
Comment on lines
+30
to
+31
| - name: Build WitnessCreator JAR | ||
| run: ./gradlew --no-daemon :targets:sv-comp:WitnessCreator:shadowJar |
Contributor
Author
There was a problem hiding this comment.
As discussed could you also move the full witness creator into its own repo that publishes an artifact we can use here?
| @@ -18,8 +23,142 @@ jobs: | |||
| distribution: 'temurin' | |||
| - name: Setup Gradle | |||
| uses: gradle/actions/setup-gradle@017a9effdb900e5b5b2fddfb590a105619dca3c3 # v4 | |||
Contributor
Author
There was a problem hiding this comment.
While you are at it, could you also check why the setup-gradle v4 is referenced using this hash I assume? is that the proper way to do that? (I know this is older then your changes but I was wondering for some time)
Contributor
Author
There was a problem hiding this comment.
This entire package of supporting file should then also move into the supporting repo I guess?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.