Skip to content

Tests: Switch tests using ldap adparameters ported to ldifde#8805

Open
jakub-vavra-cz wants to merge 1 commit into
SSSD:masterfrom
jakub-vavra-cz:ad_ldif
Open

Tests: Switch tests using ldap adparameters ported to ldifde#8805
jakub-vavra-cz wants to merge 1 commit into
SSSD:masterfrom
jakub-vavra-cz:ad_ldif

Conversation

@jakub-vavra-cz

Copy link
Copy Markdown
Contributor

Some tests were using ldap/ldif commands from client without tls/ssl which is disabled on AD 2025. Run the commands using ldifde.exe on AD directly instead.

@jakub-vavra-cz jakub-vavra-cz requested a review from danlavu June 11, 2026 12:14
@jakub-vavra-cz jakub-vavra-cz changed the title Tests: Switch test using ldap adparameters ported to ldifde Tests: Switch tests using ldap adparameters ported to ldifde Jun 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors Active Directory (AD) parameter tests to use ldifde.exe on the AD host instead of running ldapmodify/ldapadd/ldapdelete on the client. It also introduces base64 encoding for SSH public keys, adds a retry loop when searching for AD users to handle replication delays, and marks a test as flaky. The review feedback highlights that using a static filename like mod.ldif on the AD host can cause race conditions or conflicts, and recommends using unique filenames. Additionally, the reviewer advises against using raiseonerr=False without checking the return code, as this silently ignores setup and modification failures, and suggests letting these commands raise errors on failure instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/tests/multihost/ad/test_adparameters_ported.py
Comment thread src/tests/multihost/ad/test_adparameters_ported.py
Comment thread src/tests/multihost/ad/test_adparameters_ported.py
Comment thread src/tests/multihost/ad/test_adparameters_ported.py
Comment thread src/tests/multihost/ad/test_adparameters_ported.py
Some tests were using ldap/ldif commands from client without tls/ssl
which is disabled on AD 2025. Run the commands using ldifde.exe on AD
directly instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants