Tests: Switch tests using ldap adparameters ported to ldifde#8805
Tests: Switch tests using ldap adparameters ported to ldifde#8805jakub-vavra-cz wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors Active Directory (AD) parameter tests to use ldifde.exe on the AD host instead of running ldapmodify/ldapadd/ldapdelete on the client. It also introduces base64 encoding for SSH public keys, adds a retry loop when searching for AD users to handle replication delays, and marks a test as flaky. The review feedback highlights that using a static filename like mod.ldif on the AD host can cause race conditions or conflicts, and recommends using unique filenames. Additionally, the reviewer advises against using raiseonerr=False without checking the return code, as this silently ignores setup and modification failures, and suggests letting these commands raise errors on failure instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Some tests were using ldap/ldif commands from client without tls/ssl which is disabled on AD 2025. Run the commands using ldifde.exe on AD directly instead.
Some tests were using ldap/ldif commands from client without tls/ssl which is disabled on AD 2025. Run the commands using ldifde.exe on AD directly instead.