[autobackport: sssd-2-10] Tests: Update LdapOperations to fail on bind immediately#8748
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the LDAP initialization in utils.py to use the correct self.uri (which includes the port if specified) instead of the un-ported uri. It also adds error handling to raise an LdapException if the connection binding fails and returns a tuple. There are no review comments, so no additional feedback is provided.
spoore1
left a comment
There was a problem hiding this comment.
LGTM. matches other backports and original. test failures not related to code change for multihost tests.
Co-authored-by: Cursor <cursoragent@cursor.com> Reviewed-by: Scott Poore <spoore@redhat.com> (cherry picked from commit 9df13ca)
|
The pull request was accepted by @spoore1 with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
ee5cac4 to
b83579a
Compare
This is an automatic backport of PR#8740 Tests: Update LdapOperations to fail on bind immediately to branch sssd-2-10, created by @jakub-vavra-cz.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
9df13ca - Tests: Update LdapOperations to fail on bind immediately
Backported commits
Original Pull Request Body
Summary
LdapOperations.__init__when LDAP bind fails, raisingLdapExceptioninstead of keeping a tuple inself.connself.uriso optional custom port values are honored'tuple' object has no attribute 'modify_s'and surface the real bind problem early