sudo: Include CIDR notation in host filter#8738
Draft
shridhargadekar wants to merge 1 commit into
Draft
Conversation
Include (sudoHost=*/*) in LDAP filter to retrieve rules with CIDR notation. Delegates network range matching to sudo, following the same pattern as netgroups and regexps. Fixes: sudoHost with CIDR notation excluded from host filte
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the LDAP sudo provider in src/providers/ldap/sdap_async_sudo.c to include a filter for sudoHost entries containing CIDR notation (matching */*). It also includes a safety check to handle potential memory allocation failures when appending this filter. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include (sudoHost=/) in LDAP filter to retrieve rules with CIDR notation. Delegates network range matching to sudo, following the same pattern as netgroups and regexps.
Fixes: sudoHost with CIDR notation excluded from host filte