Skip to content

Removed Exposure investigation period reminder for Giardiasis - #14115

Merged
Pa-Touche merged 1 commit into
developmentfrom
fix/14094-msg
Jul 1, 2026
Merged

Pa-Touche merged 1 commit into
developmentfrom
fix/14094-msg

Conversation

@Pa-Touche

@Pa-Touche Pa-Touche commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Fixes #14094

Summary by CodeRabbit

  • New Features

    • Added more general exposure-investigation guidance for contact workflows across multiple languages, including instructions for documenting direct exposures during the incubation period.
  • Bug Fixes

    • Removed disease-specific Giardia guidance and updated the UI to use the broader exposure-investigation wording.
    • Updated localized help texts for exposure period labeling, relevant epi-data field hints, source-case/contact documentation, “no source case” messaging, and “discard changes” guidance when creating a new contact.
  • Chores

    • Updated locale text file encoding markers to improve consistency when loading translations.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b22314c7-70e7-4cb2-80af-ce6fb8e42611

📥 Commits

Reviewing files that changed from the base of the PR and between 69ab082 and ea66aec.

📒 Files selected for processing (32)
  • sormas-api/src/main/java/de/symeda/sormas/api/i18n/Strings.java
  • sormas-api/src/main/resources/strings.properties
  • sormas-api/src/main/resources/strings_ar-SA.properties
  • sormas-api/src/main/resources/strings_cs-CZ.properties
  • sormas-api/src/main/resources/strings_de-CH.properties
  • sormas-api/src/main/resources/strings_de-DE.properties
  • sormas-api/src/main/resources/strings_en-AF.properties
  • sormas-api/src/main/resources/strings_en-GH.properties
  • sormas-api/src/main/resources/strings_en-GM.properties
  • sormas-api/src/main/resources/strings_en-KE.properties
  • sormas-api/src/main/resources/strings_en-LR.properties
  • sormas-api/src/main/resources/strings_en-NG.properties
  • sormas-api/src/main/resources/strings_es-BO.properties
  • sormas-api/src/main/resources/strings_es-CU.properties
  • sormas-api/src/main/resources/strings_fa-AF.properties
  • sormas-api/src/main/resources/strings_fi-FI.properties
  • sormas-api/src/main/resources/strings_fr-CH.properties
  • sormas-api/src/main/resources/strings_fr-FR.properties
  • sormas-api/src/main/resources/strings_fr-TN.properties
  • sormas-api/src/main/resources/strings_it-CH.properties
  • sormas-api/src/main/resources/strings_it-IT.properties
  • sormas-api/src/main/resources/strings_ka-GE.properties
  • sormas-api/src/main/resources/strings_pl-PL.properties
  • sormas-api/src/main/resources/strings_ps-AF.properties
  • sormas-api/src/main/resources/strings_pt-BR.properties
  • sormas-api/src/main/resources/strings_pt-CV.properties
  • sormas-api/src/main/resources/strings_ru-RU.properties
  • sormas-api/src/main/resources/strings_sr-CS.properties
  • sormas-api/src/main/resources/strings_sw-TZ.properties
  • sormas-api/src/main/resources/strings_ur-PK.properties
  • sormas-api/src/main/resources/strings_zh-CN.properties
  • sormas-ui/src/main/java/de/symeda/sormas/ui/epidata/EpiDataForm.java
💤 Files with no reviewable changes (31)
  • sormas-api/src/main/java/de/symeda/sormas/api/i18n/Strings.java
  • sormas-api/src/main/resources/strings_es-CU.properties
  • sormas-api/src/main/resources/strings_en-NG.properties
  • sormas-api/src/main/resources/strings_en-AF.properties
  • sormas-api/src/main/resources/strings_es-BO.properties
  • sormas-api/src/main/resources/strings_en-LR.properties
  • sormas-api/src/main/resources/strings_fi-FI.properties
  • sormas-api/src/main/resources/strings_cs-CZ.properties
  • sormas-api/src/main/resources/strings_fa-AF.properties
  • sormas-api/src/main/resources/strings_sw-TZ.properties
  • sormas-api/src/main/resources/strings_ar-SA.properties
  • sormas-api/src/main/resources/strings_en-KE.properties
  • sormas-api/src/main/resources/strings_zh-CN.properties
  • sormas-api/src/main/resources/strings_sr-CS.properties
  • sormas-api/src/main/resources/strings_it-CH.properties
  • sormas-api/src/main/resources/strings_fr-TN.properties
  • sormas-api/src/main/resources/strings_de-CH.properties
  • sormas-api/src/main/resources/strings_en-GH.properties
  • sormas-api/src/main/resources/strings_pt-CV.properties
  • sormas-api/src/main/resources/strings_ka-GE.properties
  • sormas-api/src/main/resources/strings.properties
  • sormas-api/src/main/resources/strings_fr-CH.properties
  • sormas-api/src/main/resources/strings_ur-PK.properties
  • sormas-api/src/main/resources/strings_pl-PL.properties
  • sormas-api/src/main/resources/strings_fr-FR.properties
  • sormas-api/src/main/resources/strings_it-IT.properties
  • sormas-api/src/main/resources/strings_ps-AF.properties
  • sormas-api/src/main/resources/strings_en-GM.properties
  • sormas-api/src/main/resources/strings_de-DE.properties
  • sormas-api/src/main/resources/strings_ru-RU.properties
  • sormas-api/src/main/resources/strings_pt-BR.properties
🚧 Files skipped from review as they are similar to previous changes (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/epidata/EpiDataForm.java

📝 Walkthrough

Walkthrough

Removes the Giardiasis-specific exposure-investigation hint from the UI and public string contract, then updates the base and locale translation catalogs so affected locales either drop the key or replace it with generalized exposure-investigation text and related contact/incubation-period guidance.

Changes

Exposure investigation reminder update

Layer / File(s) Summary
UI hint and public constant removal
sormas-ui/src/main/java/de/symeda/sormas/ui/epidata/EpiDataForm.java, sormas-api/src/main/java/de/symeda/sormas/api/i18n/Strings.java
Removes the Giardiasis-specific exposure-investigation branch from the form text, drops the unused import, leaves the allowed-diseases list unchanged, and deletes the giardiaInfoExposureInvestigation constant.
Base catalog and direct locale replacements
sormas-api/src/main/resources/strings.properties, sormas-api/src/main/resources/strings_ar-SA.properties, sormas-api/src/main/resources/strings_cs-CZ.properties, sormas-api/src/main/resources/strings_de-DE.properties, sormas-api/src/main/resources/strings_en-AF.properties, sormas-api/src/main/resources/strings_en-GH.properties, sormas-api/src/main/resources/strings_en-GM.properties, sormas-api/src/main/resources/strings_en-KE.properties, sormas-api/src/main/resources/strings_es-CU.properties, sormas-api/src/main/resources/strings_fr-FR.properties, sormas-api/src/main/resources/strings_fr-TN.properties, sormas-api/src/main/resources/strings_fi-FI.properties, sormas-api/src/main/resources/strings_ka-GE.properties, sormas-api/src/main/resources/strings_pl-PL.properties, sormas-api/src/main/resources/strings_pt-BR.properties, sormas-api/src/main/resources/strings_ru-RU.properties, sormas-api/src/main/resources/strings_sw-TZ.properties, sormas-api/src/main/resources/strings_zh-CN.properties
Removes the base giardiaInfoExposureInvestigation entry and updates several locale files with the same key removal or a direct infoExposureInvestigation replacement, including some top-of-file BOM/header-marker changes.
Expanded exposure-investigation hints
sormas-api/src/main/resources/strings_de-CH.properties, sormas-api/src/main/resources/strings_es-BO.properties, sormas-api/src/main/resources/strings_fa-AF.properties, sormas-api/src/main/resources/strings_fr-CH.properties, sormas-api/src/main/resources/strings_it-CH.properties, sormas-api/src/main/resources/strings_it-IT.properties, sormas-api/src/main/resources/strings_ps-AF.properties, sormas-api/src/main/resources/strings_pt-CV.properties, sormas-api/src/main/resources/strings_sr-CS.properties, sormas-api/src/main/resources/strings_ur-PK.properties
Replaces the disease-specific exposure-investigation text with generalized incubation-period guidance and adds contact/source-case, exposure-period, EpiData, no-source-case, and discard-changes strings; several files also add BOM/header-marker changes.
Estimated code review effort: 2 (Simple) ~15 minutes

Possibly related PRs

Suggested reviewers: roldy, KarnaiahPesula

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning Several locale files include BOM/hidden-character edits and unrelated translation additions beyond the Giardiasis reminder fix. Remove incidental BOM-only changes and any unrelated string additions so the diff stays focused on the Giardiasis exposure-investigation reminder.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change by describing the Giardiasis exposure-investigation reminder removal.
Description check ✅ Passed The description includes the required issue reference in the expected Fixes #14094 format.
Linked Issues check ✅ Passed The EpiDataForm and localization updates remove the Giardiasis-specific reminder, matching [#14094]'s expected behavior.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/14094-msg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Pa-Touche
Pa-Touche requested a review from raulbob July 1, 2026 06:12
@Pa-Touche
Pa-Touche merged commit ebfa271 into development Jul 1, 2026
6 of 7 checks passed
@Pa-Touche
Pa-Touche deleted the fix/14094-msg branch July 1, 2026 09:10
@Pa-Touche Pa-Touche self-assigned this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Giardiasis - Epidemiological data - Exposure investigation period reminder is duplicated in some cases

2 participants