FIX: 13462: Wrongly bordered fields that are not mandatory.

[Pa-Touche]

Fixes #13462

Summary by CodeRabbit

• Style

  • Updated form field styling in case creation forms.
  • Adjusted optional field indicators in person creation forms.

• Bug Fixes

  • Refined soft-required field visibility in case and person creation forms to better reflect field requirements.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 05ea2cb1-2e17-4a64-a3d1-6747b477b5b2

📥 Commits

Reviewing files that changed from the base of the PR and between 300362a and 2d61b4c.

📒 Files selected for processing (2)

• sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseCreateForm.java
• sormas-ui/src/main/java/de/symeda/sormas/ui/person/PersonCreateForm.java

---

📝 Walkthrough

Walkthrough

The PR removes soft-required field styling from specific UI form fields. In CaseCreateForm, facilityDetails is excluded from the soft-required styling set. In PersonCreateForm, soft-required styling is removed from the presentCondition field entirely, leaving only the sex field styled as soft-required.

Changes

Cohort / File(s)	Summary
Form Field Styling Updates sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseCreateForm.java, sormas-ui/src/main/java/de/symeda/sormas/ui/person/PersonCreateForm.java	Removes soft-required styling from specific fields: facilityDetails excluded from plague-related field styling in CaseCreateForm; presentCondition field no longer styled as soft-required in PersonCreateForm.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• FIX: 13462: Wrongly bordered fields that are not mandatory #13824: Also modifies soft-required styling for person-related fields (presentCondition, sex, deathDate) to address inconsistent field styling behavior.

Suggested reviewers

• KarnaiahPesula
• obinna-h-n
• raulbob

Poem

🐰 Soft styling removed with careful care,
No more bold lines without a red star there,
Present condition now stands plain and true,
Fields match their requirements, through and through! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly references issue #13462 and describes the main fix: removing incorrect bold borders from non-mandatory fields.
Description check	✅ Passed	The description includes the required 'Fixes #13462' reference matching the template, though minimal additional detail is provided.
Linked Issues check	✅ Passed	The code changes remove soft-required styling from 'Present Condition' and 'facilityDetails' fields, directly addressing the reported issue that these non-mandatory fields were displaying with bold borders.
Out of Scope Changes check	✅ Passed	All changes are focused on removing soft-required styling from specific fields to fix the bold border issue; no unrelated modifications are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/13462-additional-input-bold-border

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sormas-vitagroup]

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13869

[sormas-vitagroup]

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13869