Skip to content

FIX: Broken test: ArchitectureTest#testNoDtosInBackend - #13867

Merged
Pa-Touche merged 1 commit into
developmentfrom
fix/13848
Mar 2, 2026
Merged

FIX: Broken test: ArchitectureTest#testNoDtosInBackend#13867
Pa-Touche merged 1 commit into
developmentfrom
fix/13848

Conversation

@Pa-Touche

@Pa-Touche Pa-Touche commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Summary by CodeRabbit

  • Tests
    • Updated internal test helper class naming for improved code organization.

@coderabbitai

coderabbitai Bot commented Mar 2, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

A test helper class is renamed from TestDto to EntityColumnTestObject with all internal references updated accordingly. No functional or behavioral changes are introduced.

Changes

Cohort / File(s) Summary
Test Helper Class Rename
sormas-backend/src/test/java/de/symeda/sormas/backend/info/EntityColumnsTest.java
Renamed test helper class from TestDto to EntityColumnTestObject and updated all field reflection and object construction references to use the new name.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A helper once called TestDto fine,
Now EntityColumnTestObject—what a sign!
Same logic flows, just a prettier name,
The rabbit approves of this renaming game! 🎭

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description only contains the template header with an empty issue reference ('Fixes #') and no additional context or explanation of the changes. Fill in the issue number after 'Fixes #' and add a description explaining what the broken test was and how the refactoring fixes it.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ⚠️ Warning The title refers to fixing a broken test (ArchitectureTest#testNoDtosInBackend), but the changeset only shows renaming a test helper class in EntityColumnsTest.java with no changes to ArchitectureTest, creating a mismatch between the title and actual changes. Update the title to accurately reflect the actual change, such as 'FIX: Rename TestDto to EntityColumnTestObject in EntityColumnsTest' or verify that all intended changes are included in this PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/13848

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sormas-vitagroup

Copy link
Copy Markdown
Contributor

@Pa-Touche Pa-Touche changed the title FIX: Broken test FIX: Broken test: ArchitectureTest#testNoDtosInBackend Mar 2, 2026
@Pa-Touche
Pa-Touche merged commit 300362a into development Mar 2, 2026
8 of 10 checks passed
@Pa-Touche
Pa-Touche deleted the fix/13848 branch March 2, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants