Unify digi format#116
Open
FelixofRivia wants to merge 6 commits into
Open
Conversation
Author
|
Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly modifyed AdvHit class to unify with raw to digi format, still inheriting from TObject to mantain compatibility with FairRoot tasks (using TClonesArray).
Added alternative MC digi workflow (same logic) using RDataFrame + RNtuple (/ TTree) + std::vector.
This requires input as vector -> added converter from TClonesArray to vector.
Compared data using vectors and TClones array, it is consistent as you can see in the plots:
My proposed next steps:
General comment: I think that this will not be the final data format / workflow, It can be optimized further depending on the choice for the SND@HL-LHC software stack, but this is an opportunity to apply and get familiar with "modern" ROOT tools / workflows. For now I tried to avoid breaking too many things.