add support for forceTransAmides option in newer RDKit versions#412
Merged
Conversation
…ult False for backwards compatibility) SO--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered when doing the RDKit update in the amshome repo: newer RDKits have gained the forceTransAmides option. The default in RDKit is "True", but "False" is actually needed to replicate the old conformer generation. (With "True", more conformers are considered duplicates, so our conformer ensembles would shrink.)
Since we need to change the default in AMS, we need to drag the option through PLAMS.