Skip to content

Prevent single failed download from killing the whole download worker #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plsdoant wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Prevent single failed download from killing the whole download worker #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,11 @@ def download_video_worker():
continue
video_path = download_video(config)
play_video_queue.put((config, video_path))
except Exception as e:
# Never let a single failed download kill the worker thread;
# otherwise every subsequent video silently fails to download.
logging.exception(f"Failed to download video: {e}")
write_log_to_client(f"Failed to download video: {e}")
finally:
download_url_queue.task_done()

Expand Down