Skip to content

Handle pending auth#137

Merged
steeevin88 merged 1 commit into
mainfrom
steven/handle_pending_auth
May 4, 2026
Merged

Handle pending auth#137
steeevin88 merged 1 commit into
mainfrom
steven/handle_pending_auth

Conversation

@steeevin88

Copy link
Copy Markdown
Contributor

CONTEXT

  • bug happened in SCEvents where we would indicate that SCEvents was down to a signed-out user, despite it being up --> moreover, signing in would then display the calendar, and then logging out would still display the calendar
  • what's the issue?
    • not sure, but we know that the /api/Auth/verify 403 returned a 403...
    • thus we have two potential reasons
      1. user's auth was somehow set to PENDING --> b/c pending is -1, we would return that the API is down
      2. user's auth token was expired --> again, we return that the API is down

CHANGES

  • update middleware to handle invalid / pending auth states --> basically allow pass if the user is signed out

@maernest04 maernest04 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let that man cook

@KhoaNguyen706 KhoaNguyen706 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@steeevin88 steeevin88 force-pushed the steven/handle_pending_auth branch from d2b91c4 to a5abf96 Compare May 4, 2026 18:48
@steeevin88 steeevin88 enabled auto-merge (squash) May 4, 2026 18:50
@steeevin88 steeevin88 merged commit 2887e0d into main May 4, 2026
3 checks passed
@steeevin88 steeevin88 deleted the steven/handle_pending_auth branch May 4, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants