Make event HC clearer, Remove unused EventCard, extract helpers#2128
Merged
Conversation
steeevin88
force-pushed
the
steven/clarify_event_hc
branch
2 times, most recently
from
92a4a79 to
ba153dc
Compare
Closed
steeevin88
force-pushed
the
steven/clarify_event_hc
branch
from
ba153dc to
d9f8ae6
Compare
KhoaNguyen706
approved these changes
May 1, 2026
KhoaNguyen706
left a comment
KhoaNguyen706
left a comment
Collaborator
There was a problem hiding this comment.
You should take a rest. Steven. btw LGTM
c1ndytat
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTEXT
SCEventscode in Clark is a bit messy; lots of shared stuff that can be refactoredCHANGES