Fix SCEvents API functions and add registration/me endpoint support#2123
Merged
Conversation
Collaborator
Author
|
I have to merge dev into my branch because i dont know how rebase would work for this situation, because dev branch is up to date |
Closed
KhoaNguyen706
force-pushed
the
khoa/fix-stuff
branch
from
6c81e27 to
ab469bc
Compare
steeevin88
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The normal view of the admin of the event:
We can fetch api from our backend right now, i dont know why but i think we have sth broken and fetch function:
The flow work quite normal:
We can edit the event right now:
We can see it works:
Can we update the user registration data UI. It look quite terrible:
closes 2121
The Cause: The code was calling new URL('/api/scevents/...'). In JavaScript, if you provide a relative path to the URL constructor, you must provide a base URL as the second argument. -> fix by updating every new URL call in src/APIFunctions/SCEvents.js to include window.location.origin as the base. Idk it yet Can we discuss on Discord ?