created route to email users their confirmation code #1997
Merged
Conversation
adarshm11
reviewed
Jan 12, 2026
Comment on lines
+2
to
+4
| if (!confirmCode) { | ||
| throw new Error('Confirmation code is required'); | ||
| } |
Contributor
There was a problem hiding this comment.
we don't need to check this because the route already checks it
| throw new Error('Confirmation code is required'); | ||
| } | ||
|
|
||
| return { |
Contributor
There was a problem hiding this comment.
can we wrap the return statement in a Promise, we should also reject the Promise if we catch an error, see unsubscribeEmail.js to see how to resolve/reject the Promise
Comment on lines
+14
to
+16
| Thank you for signing up for membership! <br /> | ||
| Here is your confirmation code:</p> | ||
| <b>${confirmCode}</b> |
Contributor
There was a problem hiding this comment.
include instructions about how they should confirm their membership, like "login to the SCE website and visit your profile to verify your membership" or something
| }); | ||
| } | ||
|
|
||
| await membershipConfirmationCode(USER, req.body.recipientEmail, req.body.confirmationCode) |
Contributor
There was a problem hiding this comment.
Suggested change
| await membershipConfirmationCode(USER, req.body.recipientEmail, req.body.confirmationCode) | |
| await membershipConfirmationCode(USER, recipientEmail, confirmationCode) |
| }) | ||
| .catch((err) => { | ||
| logger.error('unable to send confirmation code: ', err); | ||
| res.sendStatus(BAD_REQUEST); |
Contributor
There was a problem hiding this comment.
Suggested change
| res.sendStatus(BAD_REQUEST); | |
| res.sendStatus(SERVER_ERROR); |
and make sure to import this status code at the top too. i know the other routes return bad request for failures but that's wrong
Comment on lines
+180
to
+181
| logger.error('unable to send member confirmation email: ', err); | ||
| res.sendStatus(BAD_REQUEST); |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.error('unable to send member confirmation email: ', err); | |
| res.sendStatus(BAD_REQUEST); | |
| logger.error('unable to generate member confirmation email template: ', err); | |
| res.sendStatus(SERVER_ERROR); |
added 2 commits
January 12, 2026 13:19
adarshm11
reviewed
Jan 12, 2026
adarshm11
added a commit
that referenced
this pull request
Jan 27, 2026
* added membership payment schema * revised spacing * Update api/main_endpoints/models/MembershipPayment.js Co-authored-by: adarsh <110150037+adarshm11@users.noreply.github.com> * fixed syntax * Update api/main_endpoints/models/MembershipPayment.js * Update api/main_endpoints/models/MembershipPayment.js * Emily/20250104 handle membership payment confirmation (#1993) * initial commit * fixed spacing * fixed spacing 2 * fixed spacing 2 * updated logic and merged find and Verify functions * fix spacing * refactor: improve payment verification and rejection logic * fix * refactor: improve error handling in membership payment verification and rejection * fix * final fixes * final fixes * refactored updateMembershipExpiration * fix spacing * created route to email users their confirmation code (#1997) * i pray i fixed my origin * added instructions * fixed import error * fixed template formatting * made function to call email route --------- Co-authored-by: Charlynn Nguyen <charred@Charlynns-MacBook-Pro.local> * allow users to verify membership on profile (#2000) * verify-button-test-1 * fix lint * route to store new payments from gscript * payerEmail not memberEmail * import error * add logging to verifyMembership route * revise how payments are stored * bruh * dont run validators * plz work * js moment * ai * silly * return status for email send failure * evan ugarte * evan ugarte i will find you * evan ugarte you silly little chud * evan ugarte is NOT a chud <3 * tell these chuds how to pay --------- Co-authored-by: Tiffany Tran <167036717+Tyffoni@users.noreply.github.com> Co-authored-by: adarsh <110150037+adarshm11@users.noreply.github.com> Co-authored-by: Emily <162777193+codebyemily@users.noreply.github.com> Co-authored-by: Charlynn Nguyen <129462659+charred-70@users.noreply.github.com> Co-authored-by: Charlynn Nguyen <charred@Charlynns-MacBook-Pro.local> Co-authored-by: Alina Ly <alinaly.625@gmail.com> Co-authored-by: adarshm11 <amlearning2023@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue #1987
created a simple email template and route to send confirmation codes