add payment project integration by tiffany-tran07 · Pull Request #1994 · SCE-Development/Clark

tiffany-tran07 · 2026-01-06T06:04:07Z

for issue #1965

Co-authored-by: adarsh <110150037+adarshm11@users.noreply.github.com>

charred-70

lgtm tuffany is also my hero

* initial commit * fixed spacing * fixed spacing 2 * fixed spacing 2 * updated logic and merged find and Verify functions * fix spacing * refactor: improve payment verification and rejection logic * fix * refactor: improve error handling in membership payment verification and rejection * fix * final fixes * final fixes * refactored updateMembershipExpiration * fix spacing

* i pray i fixed my origin * added instructions * fixed import error * fixed template formatting * made function to call email route --------- Co-authored-by: Charlynn Nguyen <charred@Charlynns-MacBook-Pro.local>

* verify-button-test-1 * fix lint

evanugarte

can we split this into 3 prs

the changes to the email code
backend changes
react changes

evanugarte · 2026-01-23T00:50:31Z

+    return resolve({
+      from: user,
+      to: recipient,
+      subject: 'SCE Membership Confirmation',


can we put the code in the subject too

Your SCE Membership Code is ...

evanugarte · 2026-01-23T00:51:33Z

+    createdAt: {
+      type: Date,
+      default: Date.now
+    },


does mongodb already store this field? this might work

const mySchema = new mongoose.Schema({ name: String, // other fields... }, { timestamps: true });

evanugarte · 2026-01-24T01:09:00Z

+  if (amount < 20){
+    const rejected = await rejectPayment(paymentId);
+    if (rejected === null){
+      logger.error('Error rejecting payment with ID:', paymentId);
+      return res.status(SERVER_ERROR).send('Error rejecting payment.');
+    }
+    if (rejected === false){
+      logger.error('No payment found to reject with ID:', paymentId);
+      return res.status(NOT_FOUND).send('No payment found to reject.');
+    }
+    logger.info('Payment rejected due to insufficient amount. Payment ID:', paymentId);
+    return res.status(BAD_REQUEST).send('Payment amount insufficient.');
+  }


we dont need this

evanugarte · 2026-01-24T01:09:29Z

+
+  const confirmationCode = crypto.randomBytes(4).toString('hex').toUpperCase();
+  const newPayment = {
+    userId: null,


Suggested change

userId: null,

evanugarte · 2026-01-24T01:10:23Z

+async function membershipConfirmationCode(confirmCode, email) {
+  return new Promise((resolve) => {
+    axios
+      .post(`${MAILER_API_URL}/Mailer/sendMembershipConfirmationCode`, {
+        recipientEmail: email,
+        confirmationCode: confirmCode
+      })


Suggested change

async function membershipConfirmationCode(confirmCode, email) {

return new Promise((resolve) => {

axios

.post(`${MAILER_API_URL}/Mailer/sendMembershipConfirmationCode`, {

recipientEmail: email,

confirmationCode: confirmCode

})

async function membershipConfirmationCode(confirmationCode, recipientEmail) {

return new Promise((resolve) => {

axios

.post(`${MAILER_API_URL}/Mailer/sendMembershipConfirmationCode`, {

recipientEmail,

confirmationCode,

})

evanugarte · 2026-01-24T01:12:28Z

+router.post('/verifyMembership', async (req, res) => {
+  const decoded = await decodeToken(req, membershipState.PENDING);
+  if (decoded.status !== OK) {
+    return res.sendStatus(decoded.status);
+  }
+
+  const { confirmationCode } = req.body;
+  const userId = decoded.token._id;


should we rate limit this by user email, we dont have to solve that rn, just open an issue like using the decoded email from the token, if theres more than 5 requests in the past 30 min, send 429 or something

evanugarte · 2026-01-24T01:12:58Z

+  const [confirmationCode, setConfirmationCode] = useState('');
+  const { user } = useSCE();
+
+  const INPUT_CLASS_NAME = 'indent-2 block w-full rounded-md border-0 py-1.5 bg-white text-black shadow-sm ring-1 ring-inset ring-gray-300 placeholder-gray-400 focus:ring-2 focus:ring-inset focus:ring-indigo-600 sm:text-sm sm:leading-6';


move this above the function

evanugarte · 2026-01-24T01:13:21Z

+      confirmationCode,
+    );
+    if (apiResponse.error) {
+      bannerCallback('Unable to verify membership. Please try again later.');


include the http code in the title? in case they take a screenshot and post in the discord?

evanugarte · 2026-01-24T01:14:01Z

+      bannerCallback('Unable to verify membership. Please try again later.');
+      return;
+    }
+    bannerCallback('Congrats, you confirmed your membership!');


can we add the date like

you are now a member (expiration DATE_GOES_HERE)

like could the api return the date that the expiration is, if the code worked

expiration date already shows on their profile when membership is confirmed vro

as soon as the modal closes, is the profile page updated or do they need to refresh

evanugarte · 2026-01-24T01:14:32Z

+    <dialog id="verify-membership-modal" className="modal modal-bottom sm:modal-middle">
+      <div className="modal-box">
+        <h3 className="font-bold text-lg">Verify Membership</h3>
+        {accessLevel > 0 ? (
+          <>
+            <p className="text-sm text-gray-500 mt-2">
+              You are already verified!!!
+            </p>
+            <div className="modal-action">
+              <form method="dialog">
+                <div className="px-4 py-3 sm:flex sm:flex-row-reverse sm:px-6">
+                  <button
+                    className="btn inline-flex w-full justify-center rounded-md px-3 py-2 text-sm font-semibold shadow-sm ring-1 ring-inset sm:w-auto"
+                  >
+                    Close
+                  </button>
+                </div>
+              </form>
+            </div>
+          </>
+        ) : (
+          <>
+            <p className="text-sm text-gray-500 mt-2">


if (something) {

return dialog_goes_here
}

return p_class_etc_goes_here

holy nitpick ✌️

evanugarte · 2026-01-25T00:03:19Z

+const { findVerifyPayment, storePayment } = require('../util/membershipPaymentQueries.js');
+const { decodeToken } = require('../util/token-functions.js');
+const { membershipPayment = {} } = require('../../config/config.json');
+const { API_KEY = 'TUFFANYCHAR' } = membershipPayment;


be sure to update config example json to include this field

evanugarte · 2026-01-25T00:04:28Z

+  if (amount < 20) {
+    return res.status(BAD_REQUEST).send('Payment amount must be at least $20.');


we dont need this? like the validation should happen before we call this api

we should assume that an incoming request with a valid api key means we are trying to store a payment of the correct amount

evanugarte · 2026-01-25T00:06:12Z

+    return true;
+  } catch (error) {
+    logger.error('Error updating membership:', error);
+    return null;


lets return false instead of null

true if worked, false if didnt work for any reason

evanugarte · 2026-01-25T05:23:30Z

+    return resolve({
+      from: user,
+      to: recipient,
+      subject: 'SCE Membership Confirmation: Your SCE Membership Code Is...',


i meant like put the code in the subject

sorry that wasnt clear

Suggested change

subject: 'SCE Membership Confirmation: Your SCE Membership Code Is...',

subject: `Your SCE Membership Code Is ${confirmCode}`,

evanugarte · 2026-01-25T05:25:54Z

+      bannerCallback('Unable to verify membership. Please try again later.');
+      return;
+    }
+    bannerCallback('Congrats, you confirmed your membership!');


as soon as the modal closes, is the profile page updated or do they need to refresh

evanugarte · 2026-01-25T05:29:15Z

+  }
+
+  function modalContent() {
+    if (accessLevel > 0) {


use the membership state enum in

Clark/src/Enums.js

Line 23 in 35fc855

const membershipState = {

also how about we dont even show the modal button if the user is a valid member?

what do you think

good idea mr evan ugarte ❤️‍🩹

tiffany-tran07 added 2 commits January 5, 2026 22:03

added membership payment schema

fadaefa

revised spacing

469da46

adarshm11 reviewed Jan 6, 2026

View reviewed changes

Comment thread api/main_endpoints/models/MembershipPayment.js

Comment thread api/main_endpoints/models/MembershipPayment.js Outdated

Update api/main_endpoints/models/MembershipPayment.js

79276c8

Co-authored-by: adarsh <110150037+adarshm11@users.noreply.github.com>

adarshm11 reviewed Jan 6, 2026

View reviewed changes

Comment thread api/main_endpoints/models/MembershipPayment.js Outdated

fixed syntax

1eec680

adarshm11 reviewed Jan 6, 2026

View reviewed changes

Comment thread api/main_endpoints/models/MembershipPayment.js Outdated

Update api/main_endpoints/models/MembershipPayment.js

197dd13

adarshm11 reviewed Jan 6, 2026

View reviewed changes

Comment thread api/main_endpoints/models/MembershipPayment.js Outdated

Update api/main_endpoints/models/MembershipPayment.js

56ca2bb

adarshm11 approved these changes Jan 6, 2026

View reviewed changes

charred-70 approved these changes Jan 6, 2026

View reviewed changes

adarshm11 changed the title ~~added membership payment schema~~ added membership payment validation Jan 7, 2026

created route to email users their confirmation code (#1997)

c6805be

* i pray i fixed my origin * added instructions * fixed import error * fixed template formatting * made function to call email route --------- Co-authored-by: Charlynn Nguyen <charred@Charlynns-MacBook-Pro.local>

adarshm11 changed the title ~~added membership payment validation~~ add payment project integration Jan 15, 2026

chubby-ducky and others added 13 commits January 15, 2026 12:00

allow users to verify membership on profile (#2000)

a2eccde

* verify-button-test-1 * fix lint

route to store new payments from gscript

c90ba85

payerEmail not memberEmail

d523dce

import error

cd9cf64

add logging to verifyMembership route

9df3182

revise how payments are stored

0c5484d

bruh

b1cc3a7

dont run validators

d86ce50

plz work

a3a89ea

js moment

238919c

ai

b53654a

silly

ae71eed

return status for email send failure

a6d7187

evanugarte reviewed Jan 23, 2026

View reviewed changes

evanugarte reviewed Jan 24, 2026

View reviewed changes

adarshm11 added 2 commits January 23, 2026 18:00

evan ugarte

8ac1bd4

evan ugarte i will find you

1f06c33

evanugarte reviewed Jan 25, 2026

View reviewed changes

evan ugarte you silly little chud

fc61049

evanugarte reviewed Jan 25, 2026

View reviewed changes

evan ugarte is NOT a chud <3

417a726

evanugarte approved these changes Jan 26, 2026

View reviewed changes

tell these chuds how to pay

dea1fd8

adarshm11 merged commit 5758b5b into dev Jan 27, 2026
4 checks passed

adarshm11 deleted the pending-payment branch January 27, 2026 00:30

		if (amount < 20) {
		return res.status(BAD_REQUEST).send('Payment amount must be at least $20.');

	subject: 'SCE Membership Confirmation: Your SCE Membership Code Is...',
	subject: `Your SCE Membership Code Is ${confirmCode}`,

Uh oh!

Conversation

tiffany-tran07 commented Jan 6, 2026 • edited by adarshm11 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charred-70 left a comment

Choose a reason for hiding this comment

Uh oh!

evanugarte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tiffany-tran07 commented Jan 6, 2026 •

edited by adarshm11

Loading