Skip to content

remove alias and use id instead to identify and remove cards#1980

Merged
adarshm11 merged 8 commits into
devfrom
revise-card-reader-operations
Dec 31, 2025
Merged

remove alias and use id instead to identify and remove cards#1980
adarshm11 merged 8 commits into
devfrom
revise-card-reader-operations

Conversation

@tiffany-tran07

Copy link
Copy Markdown
Contributor

issue #1969

Comment on lines +174 to +176
writeLogToClient(req.method, {
statusCode: SERVER_ERROR,
message: 'Error deleting card',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's include the card's _id here as well

Comment thread src/APIFunctions/CardReader.js Outdated
'Content-Type': 'application/json',
},
body: JSON.stringify({ alias, }),
body: JSON.stringify(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
body: JSON.stringify(),
body: JSON.stringify({ _id }),

@adarshm11 adarshm11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tuffany

@n8thantran n8thantran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome sauce

@adarshm11
adarshm11 merged commit 9e69b3d into dev Dec 31, 2025
4 checks passed
@adarshm11
adarshm11 deleted the revise-card-reader-operations branch December 31, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants