OfficeAccessCard editing - UI changes#1935
Merged
Merged
Conversation
- Implemented a new endpoint to edit card aliases, including validation for input. - Updated the OfficeAccessCard utility to support alias editing. - Enhanced the CardReader component to allow users to edit card aliases directly in the UI. - Added corresponding tests to ensure proper functionality and error handling for the new feature. - Introduced a new audit log action for alias edits.
adarshm11
force-pushed
the
editalias-frontend
branch
from
October 18, 2025 18:00
abf4be8 to
15472fb
Compare
evanugarte
reviewed
Oct 18, 2025
evanugarte
left a comment
evanugarte
left a comment
Collaborator
There was a problem hiding this comment.
point this pr to editalias instead of dev, git workshop remember
that way the diff will just be the frontend changes
adarshm11
force-pushed
the
editalias-frontend
branch
from
October 18, 2025 18:46
f37ac56 to
fa3e199
Compare
evanugarte
reviewed
Oct 19, 2025
| const token = user.token; | ||
|
|
||
| // Local pencil icon for edit functionality | ||
| const pencilSymbol = (color = '#6b7280') => { |
Comment on lines
+104
to
+112
| function handleEditClick(card) { | ||
| setEditingCardId(card._id); | ||
| setEditedAlias(card.alias); | ||
| } | ||
|
|
||
| function handleCancelEdit() { | ||
| setEditingCardId(null); | ||
| setEditedAlias(''); | ||
| } |
Collaborator
There was a problem hiding this comment.
put these both in 1 function like
if editing
do stuff
return
// do cancel stuff here
Comment on lines
+149
to
+153
| if (e.key === 'Enter') { | ||
| handleSaveEdit(card._id); | ||
| } else if (e.key === 'Escape') { | ||
| handleCancelEdit(); | ||
| } |
Collaborator
There was a problem hiding this comment.
this should be a single function, like handleEditKeyDown
Comment on lines
+206
to
+209
| <svg width='20' height='20' viewBox='0 0 24 24' fill='none' stroke='#ef4444' strokeWidth='2' strokeLinecap='round' strokeLinejoin='round'> | ||
| <line x1='18' y1='6' x2='6' y2='18'></line> | ||
| <line x1='6' y1='6' x2='18' y2='18'></line> | ||
| </svg> |
Collaborator
There was a problem hiding this comment.
whatever svg this is put it in svg.js
adarshm11
force-pushed
the
editalias
branch
2 times, most recently
from
October 20, 2025 04:34
a902e38 to
a44449f
Compare
evanugarte
reviewed
Oct 21, 2025
Comment on lines
+143
to
+159
| {isEditing ? ( | ||
| <input | ||
| type='text' | ||
| value={editedAlias} | ||
| onChange={(e) => setEditedAlias(e.target.value)} | ||
| onKeyDown={(e) => handleEditKeyDown(e.key)} | ||
| className='bg-white dark:bg-gray-700 border border-gray-300 dark:border-gray-600 rounded text-gray-700 dark:text-white font-medium m-0 px-1 py-0 focus:outline-none focus:ring-1 focus:ring-blue-500' | ||
| style={{ width: '16ch' }} | ||
| autoFocus | ||
| /> | ||
| ) : ( | ||
| <div style={{ width: '16ch', display: 'flex', justifyContent: 'center', overflow: 'hidden' }}> | ||
| <span style={{ textOverflow: 'ellipsis', overflow: 'hidden', whiteSpace: 'nowrap' }}> | ||
| {card.alias} | ||
| </span> | ||
| </div> | ||
| )} |
Collaborator
There was a problem hiding this comment.
make this a function call, lke
renderInputOrAlias
and the function is like
if isEditing
return input
return div with alias
| const getColumnClassName = (columnName) => { | ||
| let className = 'px-6 py-3 whitespace-nowrap '; | ||
| if(columnName === 'lastVerifiedAt' | columnName === 'registrationDate'){ | ||
| if(columnName === 'lastVerifiedAt' || columnName === 'registrationDate'){ |
Collaborator
There was a problem hiding this comment.
you could use includes here like
[1,2].includes(1) returns true
evanugarte
approved these changes
Oct 21, 2025
adarshm11
added a commit
that referenced
this pull request
Oct 21, 2025
* Add edit alias functionality for OfficeAccessCard (#1900) - Implemented a new endpoint to edit card aliases, including validation for input. - Updated the OfficeAccessCard utility to support alias editing. - Enhanced the CardReader component to allow users to edit card aliases directly in the UI. - Added corresponding tests to ensure proper functionality and error handling for the new feature. - Introduced a new audit log action for alias edits. * fixed lint issues * fixed issues with edit alias * fixed input re-sizing * fix token decoding for office cards * fix failing test * separate frontend changes * Add edit alias functionality for OfficeAccessCard (#1900) - Implemented a new endpoint to edit card aliases, including validation for input. - Updated the OfficeAccessCard utility to support alias editing. - Enhanced the CardReader component to allow users to edit card aliases directly in the UI. - Added corresponding tests to ensure proper functionality and error handling for the new feature. - Introduced a new audit log action for alias edits. * fixed lint issues * fixed issues with edit alias * fixed input re-sizing * fix token decoding for office cards * fix failing test * separate frontend changes * modify required checks for /edit * addressed requested changes * try to fix failing test * try to fix that failing test one more time * remove this test cuz it wont work * OfficeAccessCard editing - UI changes (#1935) * Add edit alias functionality for OfficeAccessCard (#1900) - Implemented a new endpoint to edit card aliases, including validation for input. - Updated the OfficeAccessCard utility to support alias editing. - Enhanced the CardReader component to allow users to edit card aliases directly in the UI. - Added corresponding tests to ensure proper functionality and error handling for the new feature. - Introduced a new audit log action for alias edits. * fixed lint issues * fixed issues with edit alias * fixed input re-sizing * fix token decoding for office cards * fix failing test * card reader frontend * rebase * undo diff * fixed requested changes * fixed requested changes --------- Co-authored-by: DavidN016 <david.a.nguyen01@sjsu.edu> --------- Co-authored-by: DavidN016 <david.a.nguyen01@sjsu.edu> Co-authored-by: adarshm11 <amlearning2023@gmail.com> Co-authored-by: adarsh <110150037+adarshm11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.