Skip to content

Convert Advertisement expiration to a date input#1760

Merged
evanugarte merged 17 commits into
devfrom
addingAdvertisement2
Aug 2, 2025
Merged

Convert Advertisement expiration to a date input#1760
evanugarte merged 17 commits into
devfrom
addingAdvertisement2

Conversation

@leishaaf

@leishaaf leishaaf commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

resolves #1727

image

setDay(event.target.value);
}}
/>
{expireButtonClicked ? (

@evanugarte evanugarte Jul 14, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this a function called maybeRenderExpirationInput

you can call it like

<div ...>
  {maybeRenderExpirationInput()}
</div>

and the function can have an in statement like

if (!expireButtonClicked) {
  return <button ...> {/* button stuff here */} </button>
}
// down here return the input 

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@evanugarte
evanugarte force-pushed the addingAdvertisement2 branch from 5d3e1fb to 9ad2608 Compare August 2, 2025 18:05
@evanugarte evanugarte changed the title Adding advertisement2 Convert Advertisement expiration to a date input Aug 2, 2025

@thebeninator thebeninator left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wayngo wayngo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@armanbance armanbance left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@evanugarte
evanugarte merged commit c01b0b4 into dev Aug 2, 2025
4 checks passed
@evanugarte
evanugarte deleted the addingAdvertisement2 branch August 2, 2025 20:23
This was referenced Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert Advertisement expiration to a date input

5 participants