Convert Advertisement expiration to a date input#1760
Merged
Conversation
evanugarte
reviewed
Jul 14, 2025
| setDay(event.target.value); | ||
| }} | ||
| /> | ||
| {expireButtonClicked ? ( |
Collaborator
There was a problem hiding this comment.
make this a function called maybeRenderExpirationInput
you can call it like
<div ...>
{maybeRenderExpirationInput()}
</div>
and the function can have an in statement like
if (!expireButtonClicked) {
return <button ...> {/* button stuff here */} </button>
}
// down here return the input
leishaaf
force-pushed
the
addingAdvertisement2
branch
from
July 20, 2025 02:46
c1c9568 to
5d3e1fb
Compare
evanugarte
force-pushed
the
addingAdvertisement2
branch
from
August 2, 2025 18:05
5d3e1fb to
9ad2608
Compare
evanugarte
approved these changes
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1727