Feature/eeg by moperezs · Pull Request #2 · SCAI-Lab/healthcare_msgs

moperezs · 2025-09-18T13:37:28Z

No description provided.

…isition class

…plemented first draft of concentration message

…brain decoding of concentration. Added for helper folder for a better overview over 2D windowing source.

…ding in the new folder. Implemented erp signal and information

moperezs

There are some eeg cap companies that provide APIs. Not sure if you already took a look, but it could be a good example to cross validate the message types and fields.
I leave here some links to some that you may work in the future with:

…GeneralInfo.msg Co-authored-by: Monica Perez Serrano <moperez@ethz.ch>

… up comments for clarity Update BrainDecodingConcentration.msg to rename signal_quality to quality for consistency. removed unused source file format

…msgs into feature/eeg

…ERP.msg

…GeneralInfo.msg

TCUL8 · 2025-10-21T15:45:57Z

+# Output Values
+
+float32  confidence					    # Optional model confidence			
+float32 signal_quality                  # From 0 (poor) to 1 (excellent)


sorry which comment does this refer to?

TCUL8 · 2025-10-21T15:51:53Z

+
+uint8 units
+
+FilterBase[] filters


I don't think so. I have not heard about using one multiple times. so should I use this message type nested?

Sign in to view

+# Output Values
+
+float32  confidence					    # Optional model confidence			
+float32 signal_quality                  # From 0 (poor) to 1 (excellent)


Sign in to view

+
+uint8 units
+
+FilterBase[] filters


…uality

…msgs into feature/eeg

…r clarity and consistency. Implemented sleep_stage

… and improve clarity. Removed sample payload

…ced documentation

TCUL8 · 2025-10-29T08:34:37Z

I don't know why but I cannot reply to your comments directly. Both features are crucial when Classifying ERP. the latency is the time from the trigger to a certain ERP. As there are standard time spans this info is very important. The same for amplitude becausethere are also standards for this feature for each ERP

…array formatting in EEGInfo.msg

moperezs · 2025-10-29T10:30:10Z

I don't know why but I cannot reply to your comments directly. Both features are crucial when Classifying ERP. the latency is the time from the trigger to a certain ERP. As there are standard time spans this info is very important. The same for amplitude becausethere are also standards for this feature for each ERP

Hey @TCUL8 ! Alright let's keep the features. I was wondering if we could rename these two to make them more general. Since ERP can also be computed from other raw signals coming from the brain, like MEG

So maybe we could rename these:

uint8 EEG_FEATURE_AMPLITUDE                 = 70
uint8 EEG_FEATURE_LATENCY				    = 71

to something like (?)

uint8 RAW_SIGNAL_FEATURE_AMPLITUDE                 = 70
uint8 RAW_SIGNAL_FEATURE_LATENCY				    = 71

wdyt?

…msgs into feature/eeg

…brain decoding

TCUL8 · 2025-10-30T12:24:47Z

I already did rename those.

TCUL8 and others added 9 commits September 8, 2025 12:09

Proposed folder structure for pipelines. Implemented sample data acqu…

d456cc1

…isition class

Inserted files from the other feature branch

0dee2c2

Corrected naming in EEG info

dcbfb0f

Deleted pipeline from project. Created messaging 4 brain decoding. Im…

4087421

…plemented first draft of concentration message

ic

7869118

Added important features to EEG, EegInfo as well as to both parts of …

83e4920

…brain decoding of concentration. Added for helper folder for a better overview over 2D windowing source.

Merged with feature/healthcare_msgs

30488ee

Merged with feature/healthcare_msgs

0029cdc

Update MedicalDeviceSystem.msg

2f9329e

This comment was marked as resolved.

Sign in to view

KleinCaesar and others added 7 commits September 24, 2025 10:30

worked on comments

ba350f3

Extracted general brainDecodingInformation. Also separated brain deco…

9218cd9

…ding in the new folder. Implemented erp signal and information

Implemented source_file_formart to EegInfo

4f552df

Implemented movement and body part for motor imaginary message

9df7757

more features

077d833

recover

10cd663

Implemented The first version of skin staging m

9384c5b

This comment was marked as resolved.

Sign in to view

Added EEG preprocessing in BrainDecoding EEG info messages

9685426

moperezs commented Oct 19, 2025

View reviewed changes

Comment thread msg/biosensing/derived_biosignals/brain_decoding/BrainDecodingConcentration.msg Outdated

Comment thread msg/biosensing/derived_biosignals/brain_decoding/BrainDecodingGeneralInfo.msg

Comment thread msg/biosensing/derived_biosignals/brain_decoding/BrainDecodingGeneralInfo.msg Outdated

Tjalf and others added 9 commits October 20, 2025 17:41

Update .gitignore to include itself in the ignore list

5d7fd57

Remove .gitignore file from the repository

a5e6f98

Remove tash list filefrom versioning

37c4b85

Fix variable name for EEG data in message definition

21ec12a

Update msg/biosensing/derived_biosignals/brain_decoding/BrainDecoding…

015cd0a

…GeneralInfo.msg Co-authored-by: Monica Perez Serrano <moperez@ethz.ch>

Refactor EEGInfo.msg by removing unused unit definitions and cleaning…

8c88105

… up comments for clarity Update BrainDecodingConcentration.msg to rename signal_quality to quality for consistency. removed unused source file format

Merge branch 'feature/eeg' of https://github.com/SCAI-Lab/healthcare_…

33316b4

…msgs into feature/eeg

Update msg/biosensing/derived_biosignals/brain_decoding/BrainDecoding…

ed1e4de

…ERP.msg

Update msg/biosensing/derived_biosignals/brain_decoding/BrainDecoding…

9ae4cf6

…GeneralInfo.msg

moperezs commented Oct 23, 2025

View reviewed changes

Comment thread msg/biosensing/derived_biosignals/brain_decoding/Concentration.msg Outdated

TCUL8 reviewed Oct 27, 2025

View reviewed changes

moperezs commented Oct 27, 2025

View reviewed changes

Tjalf added 5 commits October 28, 2025 09:00

Changed the name of general msg types And changed signal_quality to q…

61d1176

…uality

Merge branch 'feature/eeg' of https://github.com/SCAI-Lab/healthcare_…

de8e533

…msgs into feature/eeg

Refine confidence field descriptions across multiple message files fo…

29a7450

…r clarity and consistency. Implemented sleep_stage

Refactor brain decoding message files to unify feature representation…

737a7a1

… and improve clarity. Removed sample payload

Add comments field to multiple brain decoding message files for enhan…

5ffcee0

…ced documentation

This comment was marked as resolved.

Sign in to view

Delete tash list

62c8ba6

moperezs commented Oct 28, 2025

View reviewed changes

moperezs added 3 commits October 28, 2025 19:11

Apply suggestions from code review

552026b

Update BrainDecodingMotorIm.msg

6ce4994

Merge branch 'feature/healthcare_msgs' into feature/eeg

e879931

Fix ERP feature naming in BrainDecodingERPInfo.msg and adjust filter …

a672f42

…array formatting in EEGInfo.msg

TCUL8 reviewed Oct 29, 2025

View reviewed changes

Comment thread msg/biosensing/raw_biosignals/EEG.msg

Tjalf added 2 commits October 30, 2025 09:21

Merge branch 'feature/eeg' of https://github.com/SCAI-Lab/healthcare_…

931754f

…msgs into feature/eeg

Add MotorImagery.msg to define body part and movement type enums for …

e0606fa

…brain decoding

moperezs merged commit 9fd190f into feature/healthcare_msgs Oct 30, 2025
0 of 5 checks passed

moperezs deleted the feature/eeg branch November 1, 2025 18:41

Uh oh!

Conversation

moperezs commented Sep 18, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

moperezs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TCUL8 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

TCUL8 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TCUL8 commented Oct 29, 2025

Uh oh!

Uh oh!

moperezs commented Oct 29, 2025

Uh oh!

TCUL8 commented Oct 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants