Skip to content

chore: forward requestconfig to deployment api calls - #2074

Open
davidkna-sap wants to merge 5 commits into
mainfrom
davidkna-sap/requestconfig
Open

chore: forward requestconfig to deployment api calls#2074
davidkna-sap wants to merge 5 commits into
mainfrom
davidkna-sap/requestconfig

Conversation

@davidkna-sap

@davidkna-sap davidkna-sap commented Jul 23, 2026

Copy link
Copy Markdown
Member

Context

Part of SAP/ai-sdk-js-backlog#621.

What this PR does and why it is needed

@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


What this PR does and why it is needed

This PR forwards the requestConfig parameter to deployment API calls when resolving deployment IDs. Previously, the requestConfig provided by callers was used only for the main inference request but was ignored during the deployment resolution step (fetching the deployment ID from the AI Core service).

Changes

  • deployment-resolver.ts: Added requestConfig?: CustomRequestConfig to the DeploymentResolutionOptions interface and updated getAllDeployments, getFoundationModelDeploymentId, and getOrchestrationDeploymentId to accept and forward the requestConfig to the underlying DeploymentApi.deploymentQuery().execute() call.

  • azure-openai-chat-client.ts & azure-openai-embedding-client.ts: Pass requestConfig to getFoundationModelDeploymentId so custom request configuration is applied during deployment resolution.

  • orchestration-client.ts & orchestration-embedding-client.ts: Pass requestConfig to getOrchestrationDeploymentId for the same reason.

Category: 🔧 Chore


  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.29.2

  • Correlation ID: 03c58f40-8684-11f1-873d-ebf1decc7f99
  • Summary Prompt: Default Prompt
  • LLM: anthropic--claude-4.6-sonnet
  • Output Template: Repository PR Template
  • Event Trigger: pull_request.opened
  • File Content Strategy: Full file content

…onfig

* origin/main: (67 commits)
  chore(deps): update dependency @upstash/context7-mcp to v4 (#2147)
  chore: Fix release workflow (#2130)
  chore(deps): update slackapi/slack-github-action action to v4 (#2143)
  chore(deps): update langchain (#2145)
  chore(deps): update github/codeql-action action to v4.37.6 (#2142)
  chore(deps): update dependency openai to v7.4.0 (#2141)
  chore(deps): update blackduck-inc/black-duck-security-scan action to v2.11.0 (#2140)
  chore(deps): update zizmorcore/zizmor-action action to v0.6.2 (#2139)
  chore(deps): update oasdiff/oasdiff-action action to v0.1.11 (#2138)
  chore(deps): update github/codeql-action action to v4.37.5 (#2137)
  chore(deps): update dependency @langchain/langgraph to v1.4.9 (#2136)
  chore(deps): update dependency oxlint to v1.77.0 (#2135)
  chore(deps): update dependency hyparquet-writer to v0.16.5 (#2131)
  chore(deps): update dependency jose to v6.2.8 (#2133)
  v2.14.0
  chore: Update orchestration specification (#2002)
  chore(audit): resolve audit warnings (2026-08-04) (#2106)
  chore(deps): update sap-cloud-sdk to v4.8.0 (#2118)
  chore(deps): update dependency hyparquet-writer to v0.16.4 (#2128)
  chore(deps): update dependency jose to v6.2.7 (#2127)
  ...
Comment on lines +292 to +296
export async function getFoundationModelDeploymentId(
modelDeployment: ModelDeployment,
executableId: string,
destination?: HttpDestinationOrFetchOptions
destination?: HttpDestinationOrFetchOptions,
requestConfig?: CustomRequestConfig

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pp] I don't like it when functions have more than 3 parameters, especially when the last two are optional. Given, that this is an internal function, I would prefer it, if we combined destination and requestConfig into one parameter. Maybe even adding modelDeployment.
What do you think about that?

…onfig

* origin/main: (69 commits)
  chore(deps): update dependency pnpm/pnpm to v12 (#2227)
  chore: update contributing guide
  chore(deps): update dependency @langchain/langgraph to v1.4.13 (#2228)
  chore(deps): update github/codeql-action action to v4.37.9 (#2226)
  chore(deps): update dependency knip to v6.32.3 (#2225)
  chore(deps): update dependency vale-cli/vale to v3.18.0 (#2224)
  chore(deps): update dependency pnpm/pnpm to v11.24.0 (#2223)
  chore(deps): update github/codeql-action action to v4.37.8 (#2222)
  chore(deps): update dependency oxlint to v1.80.0 (#2221)
  chore(deps): update dependency oxfmt to v0.65.0 (#2220)
  chore: fix sample code response input types (#2216)
  chore(deps): update dependency orval to v8.26.0 (#2219)
  chore: fix smoke test (#2217)
  chore(sample-code): correct docstring vendor references for Anthropic models (#2213)
  chore(oxfmt): enable import sorting (#2207)
  chore(deps): update sap-cloud-sdk to v4.9.1 (#2210)
  chore(deps): update dependency orval to v8.25.0 (#2212)
  chore(deps): update dependency jose to v6.2.10 (#2211)
  chore(deps): update dependency @upstash/context7-mcp to v4.0.3 (#2209)
  chore: fix some typos (#2203)
  ...
@davidkna-sap
davidkna-sap requested a review from marikaner August 31, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants