chore: forward requestconfig to deployment api calls - #2074
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: What this PR does and why it is neededThis PR forwards the Changes
Category: 🔧 Chore
PR Bot InformationVersion:
|
…onfig * origin/main: (67 commits) chore(deps): update dependency @upstash/context7-mcp to v4 (#2147) chore: Fix release workflow (#2130) chore(deps): update slackapi/slack-github-action action to v4 (#2143) chore(deps): update langchain (#2145) chore(deps): update github/codeql-action action to v4.37.6 (#2142) chore(deps): update dependency openai to v7.4.0 (#2141) chore(deps): update blackduck-inc/black-duck-security-scan action to v2.11.0 (#2140) chore(deps): update zizmorcore/zizmor-action action to v0.6.2 (#2139) chore(deps): update oasdiff/oasdiff-action action to v0.1.11 (#2138) chore(deps): update github/codeql-action action to v4.37.5 (#2137) chore(deps): update dependency @langchain/langgraph to v1.4.9 (#2136) chore(deps): update dependency oxlint to v1.77.0 (#2135) chore(deps): update dependency hyparquet-writer to v0.16.5 (#2131) chore(deps): update dependency jose to v6.2.8 (#2133) v2.14.0 chore: Update orchestration specification (#2002) chore(audit): resolve audit warnings (2026-08-04) (#2106) chore(deps): update sap-cloud-sdk to v4.8.0 (#2118) chore(deps): update dependency hyparquet-writer to v0.16.4 (#2128) chore(deps): update dependency jose to v6.2.7 (#2127) ...
| export async function getFoundationModelDeploymentId( | ||
| modelDeployment: ModelDeployment, | ||
| executableId: string, | ||
| destination?: HttpDestinationOrFetchOptions | ||
| destination?: HttpDestinationOrFetchOptions, | ||
| requestConfig?: CustomRequestConfig |
There was a problem hiding this comment.
[pp] I don't like it when functions have more than 3 parameters, especially when the last two are optional. Given, that this is an internal function, I would prefer it, if we combined destination and requestConfig into one parameter. Maybe even adding modelDeployment.
What do you think about that?
…onfig * origin/main: (69 commits) chore(deps): update dependency pnpm/pnpm to v12 (#2227) chore: update contributing guide chore(deps): update dependency @langchain/langgraph to v1.4.13 (#2228) chore(deps): update github/codeql-action action to v4.37.9 (#2226) chore(deps): update dependency knip to v6.32.3 (#2225) chore(deps): update dependency vale-cli/vale to v3.18.0 (#2224) chore(deps): update dependency pnpm/pnpm to v11.24.0 (#2223) chore(deps): update github/codeql-action action to v4.37.8 (#2222) chore(deps): update dependency oxlint to v1.80.0 (#2221) chore(deps): update dependency oxfmt to v0.65.0 (#2220) chore: fix sample code response input types (#2216) chore(deps): update dependency orval to v8.26.0 (#2219) chore: fix smoke test (#2217) chore(sample-code): correct docstring vendor references for Anthropic models (#2213) chore(oxfmt): enable import sorting (#2207) chore(deps): update sap-cloud-sdk to v4.9.1 (#2210) chore(deps): update dependency orval to v8.25.0 (#2212) chore(deps): update dependency jose to v6.2.10 (#2211) chore(deps): update dependency @upstash/context7-mcp to v4.0.3 (#2209) chore: fix some typos (#2203) ...
Context
Part of SAP/ai-sdk-js-backlog#621.
What this PR does and why it is needed