feat(orchestration): Allow array for encoding_format in EmbeddingModelParams - #1823
Draft
InjunPark-sap wants to merge 1 commit into
Draft
feat(orchestration): Allow array for encoding_format in EmbeddingModelParams#1823InjunPark-sap wants to merge 1 commit into
InjunPark-sap wants to merge 1 commit into
Conversation
InjunPark-sap
changed the title
davidkna-sap
reviewed
May 5, 2026
davidkna-sap
left a comment
davidkna-sap
left a comment
Member
There was a problem hiding this comment.
I think we were discussing if this needs additional convenience.
In general, you probably want to revert all changes from #1740 as part of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
EmbeddingModelParams.encoding_format:EncodingFormat→EncodingFormat | EncodingFormat[]Why
The generated spec (
embeddings-model-params.ts) already allowsEncodingFormat | EncodingFormat[], but the SDK public type was more restrictive.Cohere Embed v4 accepts an array of
embedding_typesand returnsEmbeddingMultiFormat— this change unblocks that use case.