Skip to content

DIARCHERS-610: generate batch token to connect vault - #589

Merged
liuwei08 merged 20 commits into
masterfrom
DIARCHERS-610
Dec 2, 2025
Merged

DIARCHERS-610: generate batch token to connect vault#589
liuwei08 merged 20 commits into
masterfrom
DIARCHERS-610

Conversation

@sdencer

@sdencer sdencer commented Oct 16, 2025

Copy link
Copy Markdown

No description provided.

@sdencer
sdencer requested a review from liuwei08 October 16, 2025 08:08
Comment thread src/api/handlers/job_api.py Outdated
liuwei08
liuwei08 previously approved these changes Oct 16, 2025
@liuwei08
liuwei08 self-requested a review November 21, 2025 06:12

@liuwei08 liuwei08 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this error in rel env, https://infrabox.datahub.only.sap/dashboard/#/project/rms/build/45609/1/job/generator%2Fbuild-testjumpbox-server-csi-image.1, Please fix this bug
File "/infrabox/api/handlers/job_api.py", line 454, in get
secret = get_secret(json.dumps(password))
File "/infrabox/api/handlers/job_api.py", line 416, in get_secret
batch_token = vault_client.generate_batch_token(token_to_use)
File "/infrabox/api/handlers/job_api.py", line 99, in generate_batch_token
if 'token-creator' in self.policies:
TypeError: argument of type 'NoneType' is not iterable
21-11-2025:05:58:52,918 INFO [job_api.py:414] validate way is appRole
21-11-2025:05:58:53,134 ERROR [app.py:1891] Exception on /api/job/job [GET]
Traceback (most recent call last):

@liuwei08
liuwei08 self-requested a review November 21, 2025 06:14
@liuwei08
liuwei08 dismissed their stale review November 21, 2025 06:15

There is a bug in code

@liuwei08
liuwei08 merged commit 59d9b59 into master Dec 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants