Skip to content

Next range #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonmarklar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Next range #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a69bac6
add validation, auto increment range to next offset
simonmarklar May 24, 2020
5d84067
remove uneeded max check
simonmarklar May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions DownloadCollection.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,45 @@ var albumLoadDuration = 10000;
downloadRangeButton.onclick = () => {
var rangeStart = parseInt(downloadRangeStart.value)
var rangeEnd = parseInt(downloadRangeEnd.value)
var ok = true

@RyanBluth RyanBluth May 25, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to a better name like 'rangeValid' or 'validRange'?

if (rangeStart < 0 || rangeStart >= allLinks.length) {
downloadRangeStart.value = null
ok = false
}
if (rangeEnd < 0 || rangeEnd >= allLinks.length) {
downloadRangeEnd.value = null
ok = false
}

if (!ok) {
return
}
for(var i = rangeStart; i <= rangeEnd && i < allLinks.length; i++) {
window.open(allLinks[i], '_blank')
}
downloadNextRangeButton.style.display = "block"
}

var downloadNextRangeButton = document.createElement('button')
downloadNextRangeButton.innerText = 'Download next range'
downloadNextRangeButton.style.display = "none"
downloadNextRangeButton.style.marginBottom = "10px"
downloadNextRangeButton.onclick = () => {
var rangeStart = parseInt(downloadRangeStart.value)
var rangeEnd = parseInt(downloadRangeEnd.value)
var limit = rangeEnd - rangeStart + 1
downloadRangeStart.value = Math.min(rangeEnd + 1, allLinks.length - 1)
downloadRangeEnd.value = Math.min(rangeEnd + limit, allLinks.length - 1)
downloadRangeButton.click()
}


downloadControls.appendChild(downloadAllButton)
downloadControls.appendChild(downloadSelectedButton)
downloadControls.appendChild(downloadRangeButton)
downloadControls.appendChild(downloadRangeStart)
downloadControls.appendChild(downloadRangeEnd)
downloadControls.appendChild(downloadNextRangeButton)

mainContainer.appendChild(downloadControls)
mainContainer.appendChild(statusSpan)
Expand Down