Atmos and Sabre#1475
Conversation
github-actions
Bot
added
S: Untriaged
size/M
Changes: Sprites
|
RSI Diff Bot; head commit 66a72cd merging into ed64e4b Resources/Textures/Backmen/Clothing/Hands/Gloves/insulated_gloves.rsi
Resources/Textures/Backmen/Clothing/Shoes/Boots/magboots_atmos.rsi
|
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (5)
WalkthroughДобавлены новые предметы экипировки для атмос-техников, обновлены параметры тазера и капитанской сабли, а также сдвинут указатель подмодуля RobustToolbox. ChangesНовая экипировка атмос-техника
Правки баланса оружия
Обновление подмодуля RobustToolbox
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
Resources/Prototypes/Catalog/Fills/Lockers/engineer.yml (1)
171-171: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueНебольшая несогласованность форматирования комментария.
Здесь два пробела перед
#Asleep, тогда как на строке 162 — один. Не влияет на функциональность.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/Catalog/Fills/Lockers/engineer.yml` at line 171, The comment formatting in the engineer locker prototype is inconsistent because the `ClothingShoesBootsMagAtmos` entry has extra spacing before the inline comment. Update the comment alignment in the relevant fill entry so it matches the surrounding style used elsewhere in the same prototype section, keeping the `id` entry and `#Asleep` comment neatly aligned.Resources/Locale/ru-RU/prototypes/asleep/entities/clothing/hands/groves.ftl (1)
1-2: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueОпечатка в имени файла:
groves.ftlвместоgloves.ftl.Файл ru-RU локализации назван иначе, чем зеркальный en-US-путь (
.../hands/gloves.ftl), что нарушает соглашение о зеркалировании путей локализации между языками и усложняет навигацию/поиск.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Locale/ru-RU/prototypes/asleep/entities/clothing/hands/groves.ftl` around lines 1 - 2, The localization file name is misspelled as groves.ftl, which breaks the mirrored path convention with the corresponding gloves.ftl file. Rename the file to gloves.ftl so the ru-RU prototype path matches the en-US structure, and verify any references to this locale file continue to resolve through the same mirrored directory layout.Resources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.yml (1)
4-5: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueНеудачная формулировка англ. названия/описания.
name: insulated gloves atmosзвучит грамматически некорректно для англоязычного текста (в отличие от аккуратной ru-RU локализации "Утеплённые перчатки атмосов"). Стоит переформулировать, напримерatmos insulated glovesилиatmospheric technician's insulated gloves.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.yml` around lines 4 - 5, The English localization in the gloves prototype has an awkward, ungrammatical item name/description. Update the ASLEEP gloves entry by adjusting the localized fields in the gloves prototype so the label reads naturally in English, using the existing item definition for insulated atmos gear as the reference; for example, rephrase the name to something like “atmos insulated gloves” or “atmospheric technician’s insulated gloves,” and make sure the description matches that wording.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.yml`:
- Around line 13-15: In the TemperatureProtection block for the gloves entity,
the heatingCoefficient value is incorrectly above 1.0 and makes the item worse
than no protection. Update the gloves definition to use a sub-1.0
heatingCoefficient in line with other insulated/protective clothing, checking
the intended balance for this ASLEEP gloves prototype and keeping
coolingCoefficient unchanged unless the design requires otherwise.
- Around line 11-12: The Insulated prototype in gloves.yml is using an
unsupported field, so the protection setting is ignored. Update the Insulated
definition to use only valid InsulatedComponent data fields (such as
Coefficient) or remove the invalid preventOpperatinGuns entry, and verify the
prototype still maps correctly to InsulatedComponent in the clothing gloves
prototype.
---
Nitpick comments:
In `@Resources/Locale/ru-RU/prototypes/asleep/entities/clothing/hands/groves.ftl`:
- Around line 1-2: The localization file name is misspelled as groves.ftl, which
breaks the mirrored path convention with the corresponding gloves.ftl file.
Rename the file to gloves.ftl so the ru-RU prototype path matches the en-US
structure, and verify any references to this locale file continue to resolve
through the same mirrored directory layout.
In `@Resources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.yml`:
- Around line 4-5: The English localization in the gloves prototype has an
awkward, ungrammatical item name/description. Update the ASLEEP gloves entry by
adjusting the localized fields in the gloves prototype so the label reads
naturally in English, using the existing item definition for insulated atmos
gear as the reference; for example, rephrase the name to something like “atmos
insulated gloves” or “atmospheric technician’s insulated gloves,” and make sure
the description matches that wording.
In `@Resources/Prototypes/Catalog/Fills/Lockers/engineer.yml`:
- Line 171: The comment formatting in the engineer locker prototype is
inconsistent because the `ClothingShoesBootsMagAtmos` entry has extra spacing
before the inline comment. Update the comment alignment in the relevant fill
entry so it matches the surrounding style used elsewhere in the same prototype
section, keeping the `id` entry and `#Asleep` comment neatly aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 9999cc82-61b0-4c5c-a3e4-0b7396fc0e4d
⛔ Files ignored due to path filters (16)
Resources/Textures/ASLEEP/Clothing/Hands/Gloves/insulated_gloves.rsi/equipped-HAND.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Hands/Gloves/insulated_gloves.rsi/icon.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Hands/Gloves/insulated_gloves.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Hands/Gloves/insulated_gloves.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/equipped-FEET-reptilian.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/equipped-FEET-vox.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/equipped-FEET.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/icon-on.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/icon.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/on-equipped-FEET-reptilian.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/on-equipped-FEET-vox.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/on-equipped-FEET.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/on-inhand-left.pngis excluded by!**/*.pngResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/on-inhand-right.pngis excluded by!**/*.png
📒 Files selected for processing (11)
Resources/Locale/en-US/prototypes/asleep/entities/clothing/hands/gloves.ftlResources/Locale/en-US/prototypes/asleep/entities/clothing/shoes/magboots.ftlResources/Locale/ru-RU/prototypes/asleep/entities/clothing/hands/groves.ftlResources/Locale/ru-RU/prototypes/asleep/entities/clothing/shoes/magboots.ftlResources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.ymlResources/Prototypes/ASLEEP/Entities/Clothing/Shoes/magboots.ymlResources/Prototypes/Catalog/Fills/Lockers/engineer.ymlResources/Prototypes/Entities/Objects/Weapons/Guns/Battery/battery_guns.ymlResources/Prototypes/Entities/Objects/Weapons/Melee/sword.ymlResources/Textures/ASLEEP/Clothing/Hands/Gloves/insulated_gloves.rsi/meta.jsonResources/Textures/ASLEEP/Clothing/Shoes/magboots_atmos.rsi/meta.json
There was a problem hiding this comment.
♻️ Duplicate comments (1)
Resources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.yml (1)
1-21: 🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy liftОтсутствует компонент
Insulated— перчатки не защищают от удара током.Прошлый ревью-коммент указывал на некорректное поле
preventOpperatinGunsв компонентеInsulated(InsulatedComponentподдерживает толькоCoefficient). В текущей версии компонентInsulatedполностью удалён из прототипа вместо исправления поля. В итоге сущность называется "insulated gloves" и позиционируется как защитная экипировка атмос-техника, но по факту не защищает от электрошока — только от температуры (TemperatureProtection). Это выглядит как побочный эффект предыдущего фикса, а не осознанное решение.Предлагаемое исправление
- type: TemperatureProtection heatingCoefficient: 0.050 coolingCoefficient: 0.8 + - type: Insulated + coefficient: 0 - type: ButcherableСтоит уточнить корректное значение
coefficient(по аналогии с ванильными изолированными перчатками) перед мёржем.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.yml` around lines 1 - 21, The insulated gloves prototype lost its electric shock protection because the Insulated component was removed from InsulatedGlovesAtmos in gloves.yml. Restore the Insulated component on this entity and set the correct coefficient value consistent with the vanilla insulated gloves behavior, while keeping the existing TemperatureProtection and other components intact. Use the InsulatedGlovesAtmos prototype as the anchor when updating the components list.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@Resources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.yml`:
- Around line 1-21: The insulated gloves prototype lost its electric shock
protection because the Insulated component was removed from InsulatedGlovesAtmos
in gloves.yml. Restore the Insulated component on this entity and set the
correct coefficient value consistent with the vanilla insulated gloves behavior,
while keeping the existing TemperatureProtection and other components intact.
Use the InsulatedGlovesAtmos prototype as the anchor when updating the
components list.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 23a4ef5f-2eaf-4d09-ba04-83f2dd1fb0d8
📒 Files selected for processing (1)
Resources/Prototypes/ASLEEP/Entities/Clothing/Hands/gloves.yml
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 participant
Summary by CodeRabbit