Repository navigation
der: fix stack overflow decoding nested BER indefinite lengths - #2490
Merged
Merged
Conversation
The indefinite-length scanner recursively decoded nested headers without enforcing the reader's nesting limit, allowing untrusted BER input to overflow the stack and abort the process. Replace recursive scanning with an allocation-free loop that tracks open indefinite-length values and enforces the shared 64-level nesting limit. Add regression tests for excessive depth, valid nesting, sibling values, and malformed encodings.
tarcieri
force-pushed
the
der/fix-ber-stack-overflow
branch
from
October 24, 2026 20:10
1e5bb7e to
5d90299
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The indefinite-length scanner recursively decoded nested headers without enforcing the reader's nesting limit, allowing untrusted BER input to overflow the stack and abort the process.
Replace recursive scanning with an allocation-free loop that tracks open indefinite-length values and enforces the shared 64-level nesting limit.
Add regression tests for excessive depth, valid nesting, sibling values, and malformed encodings.