Repository navigation
Bump crypto-bigint to v0.7.0-rc.16 - #628
Merged
Merged
Conversation
tarcieri
commented
Jan 12, 2026
This includes changes to `BoxedMontyForm::new` that handle cloning the `Arc` around the `BoxedMontyParams` internally, rather than requiring the caller to clone it. It also renames the unchecked square root to `floor_sqrt`, which is fine for the one usage here (in the prime recovery implementation), because it immediately performs a check on the result.
tarcieri
force-pushed
the
crypto-bigint/v0.7.0-rc.16
branch
from
January 12, 2026 19:50
e6a5b49 to
d9f8564
Compare
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
This includes changes to `BoxedMontyForm::new` that handle cloning the `Arc` around the `BoxedMontyParams` internally, rather than requiring the caller to clone it. It also renames the unchecked square root to `floor_sqrt`, which is fine for the one usage here (in the prime recovery implementation), because it immediately performs a check on the result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes changes to
BoxedMontyForm::newthat handle cloning theArcaround theBoxedMontyParamsinternally, rather than requiring the caller to clone it.It also renames the unchecked square root to
floor_sqrt, which is fine for the one usage here (in the prime recovery implementation), because it immediately performs a check on the result.