Repository navigation
pss, oaep: remove DynDigest - #593
Merged
Merged
Conversation
Member
Author
baloo
force-pushed
the
baloo/remove-dyndigest
branch
from
October 14, 2025 07:20
80eca79 to
c69f0f5
Compare
I'm not sure I see why usage of `DynDigest` was originally introduced. The need to make the Digest also Send is hard to use in downstream crates. I don't believe this was necessary, this removes its use and makes the consumer specify the Digest types.
baloo
force-pushed
the
baloo/remove-dyndigest
branch
from
October 14, 2025 07:24
c69f0f5 to
36ba73e
Compare
Member
|
seems fine to me, I don't remember if there was a specific reason to use it |
Member
|
I'm also fine with it, although my guess would be it was originally there to better support digests selected at runtime with less monomorphization bloat |
tarcieri
approved these changes
Oct 14, 2025
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
I'm not sure I see why usage of `DynDigest` was originally introduced. The need to make the Digest also Send is hard to use in downstream crates. I don't believe this was necessary, this removes its use and makes the consumer specify the Digest types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure I see why usage of
DynDigestwas originally introduced. The need to make the Digest also Send is hard to use in downstream crates.I don't believe this was necessary, this removes its use and makes the consumer specify the Digest types.