gccrs: Resolve lang item types - #4803
Merged
Merged
Conversation
CohenArthur
approved these changes
Aug 20, 2026
CohenArthur
left a comment
CohenArthur
left a comment
Member
There was a problem hiding this comment.
LGTM, can you add a testcase for it? also leaving it to @philberty for review
Lang items might not already be resolved when an expression depending on them is resolved. The new test is a copy of for-loop1.rs in the same directory, but the main function item is moved towards the top of the file. It still produces a compiler error after type checking, but that can be resolved in another patch. gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit (BoxExpr)): Attempt to resolve lang item, instead of just looking it up. (TypeCheckExpr::visit (RangeFromToExpr)): Likewise. (TypeCheckExpr::visit (RangeFromExpr)): Likewise. (TypeCheckExpr::visit (RangeToExpr)): Likewise. (TypeCheckExpr::visit (RangeFullExpr)): Likewise. gcc/testsuite/ChangeLog: * rust/compile/for-loop3.rs: New test. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
Collaborator
Author
|
Added test case |
Member
|
good catch with that testcase it ices making an issue for myself for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lang items might not already be resolved when an expression depending on them is resolved.