Add lang pin/unpin - #4720
Merged
Merged
Conversation
CohenArthur
reviewed
Jul 28, 2026
CohenArthur
left a comment
CohenArthur
left a comment
Member
There was a problem hiding this comment.
The GCC5 builder is reporting a segmentation fault, code looks good to me apart from this :) well done
| // node of somekind | ||
| if (b.second == nullptr) | ||
| return true; | ||
| return predicate.get_polarity () == BoundPolarity::RegularBound; |
Member
There was a problem hiding this comment.
nit but let's add braces here since we have braces on the else
Suggested change
| return predicate.get_polarity () == BoundPolarity::RegularBound; | |
| { | |
| return predicate.get_polarity () == BoundPolarity::RegularBound; | |
| } |
powerboat9
reviewed
Aug 9, 2026
This patch adds support for structural auto-traits and fixes how negative trait implementations are handled. gcc/rust/ChangeLog: * typecheck/rust-tyty-bounds.cc (TypeBoundsProbe::add_trait_bound): Check all fields of an ADT. * typecheck/rust-tyty.cc (BaseType::satisfies_bound): Reject trait if there is a negative impl. Signed-off-by: Enes Cevik <enes@nsvke.com>
This patch adds pin/unpin lang items to the compiler but not fully tested due to issues Rust-GCC#4709 and Rust-GCC#4678 so we tested auto trait and negative impls behaviors. gcc/rust/ChangeLog: * util/rust-lang-item.cc (Rust::LangItem::lang_items): Add pin and unpin lang items to the BiMap. * util/rust-lang-item.h (class LangItem): Add PIN and UNPIN to the Kind enum. gcc/testsuite/ChangeLog: * rust/compile/lang-pin-unpin.rs: New test. Signed-off-by: Enes Cevik <enes@nsvke.com>
Collaborator
|
LGTM, but could you use |
Contributor
Author
|
I already used it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds pin/unpin lang items to the compiler but not fully tested
due to issues #4709 and #4678 so we tested
auto trait and negative impls behaviors.
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog:
This patch adds support for structural auto-traits and fixes how negative
trait implementations are handled.
gcc/rust/ChangeLog:
Closes #4760