gccrs: add type alias bounds lint - #4639
Open
lucasly-ba wants to merge 1 commit into
Open
Conversation
philberty
requested changes
Jun 29, 2026
philberty
left a comment
philberty
left a comment
Member
There was a problem hiding this comment.
LGTM but there are merge conflicts
lucasly-ba
force-pushed
the
type-alias-bounds
branch
2 times, most recently
from
June 29, 2026 21:36
e481e87 to
1557103
Compare
Member
|
merge conflicts again |
lucasly-ba
force-pushed
the
type-alias-bounds
branch
3 times, most recently
from
July 8, 2026 22:30
0e855a7 to
5af0f50
Compare
Warn on bounds applied to the generic parameters of a type alias, as those bounds are not enforced. gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. * rust-lang.cc (grs_langhook_init_options_struct): Enable warn_unused. gcc/testsuite/ChangeLog: * rust/compile/type-alias-bounds_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
lucasly-ba
force-pushed
the
type-alias-bounds
branch
from
July 9, 2026 13:35
5af0f50 to
2f0f086
Compare
Contributor
Author
|
@philberty should be good |
Contributor
Author
Member
|
mer conflicts.. just combine a few of these to make it easier |
Contributor
Author
|
@philberty just opened #4797 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the type alias bounds lint, which warns on bounds applied to the generic parameters of a type alias, since those bounds are not enforced.
Note: this branch is based on #4637 (fix ICE on generic type aliases); the first commit is that fix, without which the construct cannot be compiled. It can be rebased once #4637 lands.
gcc/testsuite/ChangeLog: