fix(engine): defer validator fail to inconclusive while the linked task is unmerged by flexi767 · Pull Request #1917 · Runfusion/Fusion

flexi767 · 2026-07-05T16:54:35Z

Problem

MissionExecutionLoop.runFeatureValidation treats a validator "fail" verdict as authoritative regardless of whether the linked task's code has actually landed. When validation fires while the task is still mid-pipeline — an in-review PR, an external merge train, a deferred base sync — the validator judges a checkout that predates the merge, concludes the feature "is not present", and handleValidationFail mints a Fix feature for work that is already done.

We hit this in production (2026-07-05): a recovery-path validation ran against four features whose implementing tasks were in-review in an external merge pipeline. All four "failed" → four duplicate Fix tasks were created one minute after the real work merged. Worse, the Fix tasks' planned file scopes included hot shared files, so their file-scope leases serialized the entire board until they were manually archived.

Fix

Before dispatching a fail verdict, resolve the linked task's column. If it affirmatively shows the task has not completed (any column other than done/archived), route the outcome to handleValidationInconclusive (R21 — completes the run as blocked, logs verification_inconclusive, notifies autopilot, spawns no Fix feature) with a "code not merged yet — validation deferred" reason. A later validation (post-merge recovery pass) judges the real merged code.

Fails open by design — the guard may only ever defer a fail, never suppress one on missing data. Missing taskId, missing task, unreadable store, or unknown column all fall through to the normal handleValidationFail path:

private async getPremergeTaskColumn(taskId: string | undefined): Promise<string | null> {
  if (!taskId) return null;
  const linkedTask = await this.taskStore.getTask(taskId).catch(() => null);
  const column = linkedTask?.column;
  if (!column || column === "done" || column === "archived") return null;
  return column;
}

The vanilla flow is unaffected: the scheduler triggers validation on toColumn === "done", so by the time a normally-triggered validation runs the task is already done and the guard is a no-op. Only recovery-path / re-validation runs that race an unmerged task are deferred.

Tests

Three new tests in mission-execution-loop.test.ts (premerge guard describe):

fail verdict + linked task in-review → routes to inconclusive: no Fix feature, run completed as blocked, validation:inconclusive emitted (not validation:failed), verification_inconclusive mission event logged
fail verdict + linked task done → normal fail path: Fix feature created, validation:failed emitted
fail verdict + taskStore.getTask rejects → fails open to the normal fail path

npx vitest run src/__tests__/mission-execution-loop.test.ts: 58/58 green. npx tsc --noEmit: clean. Full engine suite: the 46 failures across 24 files present on my branch fail identically on clean 17c4007 (verified by re-running the same files on a detached checkout of upstream main) — all pre-existing/environment-dependent, none related to this change.

Summary by CodeRabbit

Bug Fixes
- Validation failures now account for whether the linked task is actually merged. If the task is still in progress, the result is marked as inconclusive instead of creating a fix flow.
- Added clearer handling when task details can’t be read, so normal failure behavior still applies.
- Improved validation status reporting and event logging for merged vs. unmerged task states.

…sk is unmerged A "fail" verdict from runFeatureValidation is only trustworthy once the linked task's code has actually landed (column done/archived). When the task is still mid-pipeline — an in-review PR, an external merge train, a deferred base sync — the validator judged a checkout that predates the merge and reports the work as missing, minting a duplicate Fix feature (and board task) for code that is about to land. Route that case to handleValidationInconclusive (R21: no Fix feature, run completed as blocked, distinguishable verification_inconclusive event) so a later validation judges the merged code instead. The guard fails open: a missing/unlinked task, an unreadable task store, or an unknown column all keep the existing handleValidationFail path — it can only ever defer a fail on affirmative evidence of an unmerged column, never suppress one on missing data. The vanilla done-triggered flow (scheduler fires processTaskOutcome on toColumn === "done") is unaffected; the guard matters for recovery-path validations and for deployments whose tasks merge through external pipelines. Incident context: a mission validator racing an external merge train failed four features while their tasks were in-review, and the four generated Fix tasks' file-scope leases on hot shared files serialized the entire board. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

coderabbitai · 2026-07-05T16:55:16Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b4b8832-9479-46b5-b37f-f1c90f9593ec

📥 Commits

Reviewing files that changed from the base of the PR and between 17c4007 and c73c700.

📒 Files selected for processing (2)

packages/engine/src/__tests__/mission-execution-loop.test.ts
packages/engine/src/mission-execution-loop.ts

📝 Walkthrough

Walkthrough

This change modifies MissionExecutionLoop.runFeatureValidation to check the linked task's board column before handling a validator "fail" verdict. A new getPremergeTaskColumn helper determines whether the fail should be deferred as inconclusive or processed normally. Corresponding tests are added.

Changes

Premerge Guard for Validation Fail Verdict

Layer / File(s)	Summary
Premerge column check and fail routing `packages/engine/src/mission-execution-loop.ts`	Adds `getPremergeTaskColumn(taskId)` to resolve a linked task's column, returning it only when the task is not `done`/`archived`; the `"fail"` branch now routes to `handleValidationInconclusive` when the task is pre-merge, otherwise falls back to `handleValidationFail`, failing open when the task is missing or unreadable.
Premerge guard test suite `packages/engine/src/__tests__/mission-execution-loop.test.ts`	Adds tests priming a fail verdict with a linked task: verifies deferral to inconclusive (blocked status, `validation:inconclusive` emission, warning event) when task is not done, verifies normal fail flow (`validation:failed`) when task is done, and verifies fail-open behavior when the linked task cannot be read.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Runfusion/Fusion#1345: Both PRs modify runFeatureValidation in mission-execution-loop.ts, one centralizing the flow and this one adding column-based fail routing.
Runfusion/Fusion#1666: Both PRs change how the validator's "fail" outcome is routed to other terminal/inconclusive states within the same file.

Poem

A task not merged, still in review,
the guard says "wait, don't jump the queue!"
Inconclusive whispers, warning logged,
but once it's done, the fail's not dodged.
Fail open wide when data's lost —
a rabbit's caution, worth the cost. 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main behavior change in the validator flow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps · 2026-07-05T16:57:12Z

Greptile Summary

This PR defers validator failures while linked task work is still unmerged. The main changes are:

Adds a linked-task column check before handling validator fail results.
Routes pre-merge failures to the existing inconclusive path instead of creating Fix features.
Adds tests for in-review deferral, completed-task failure handling, and task-store read failures.

Confidence Score: 4/5

The changed validation flow has one contained column-handling issue to fix before merging.

The normal done path still creates Fix features.
Task-store read failures still fall through to the normal fail path.
Custom completed columns can now be misread as pre-merge and skip Fix feature creation.

packages/engine/src/mission-execution-loop.ts

Important Files Changed

Filename	Overview
packages/engine/src/mission-execution-loop.ts	Adds a pre-merge guard to the validator fail path, but the current column check also treats custom completed columns as pre-merge.
packages/engine/src/tests/mission-execution-loop.test.ts	Adds focused coverage for the new guard, including the intended defer path and fail-open behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Validator result] --> B{status}
  B -->|pass| C[handleValidationPass]
  B -->|inconclusive| D[handleValidationInconclusive]
  B -->|fail| E[Read linked task column]
  E --> F{column present and not done/archived?}
  F -->|yes| D
  F -->|no, unreadable, or missing| G[handleValidationFail]
  G --> H[Create Fix feature]
  D --> I[Complete run as blocked]

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
  A[Validator result] --> B{status}
  B -->|pass| C[handleValidationPass]
  B -->|inconclusive| D[handleValidationInconclusive]
  B -->|fail| E[Read linked task column]
  E --> F{column present and not done/archived?}
  F -->|yes| D
  F -->|no, unreadable, or missing| G[handleValidationFail]
  G --> H[Create Fix feature]
  D --> I[Complete run as blocked]

_{Reviews (1): Last reviewed commit: "fix(engine): defer validator fail to inc..." | Re-trigger Greptile}

greptile-apps · 2026-07-05T16:57:16Z

+    const column = linkedTask?.column;
+    if (!column || column === "done" || column === "archived") return null;
+    return column;


Custom Columns Defer Failures

When a project uses a custom column that means completed, such as an external merge or release column, this helper treats it as pre-merge because it returns every truthy value except done and archived. A real validator failure for that linked task is then completed as inconclusive, no Fix feature is created, and the feature can stay blocked instead of getting repaired.

Suggested change

const column = linkedTask?.column;

if (!column || column === "done" || column === "archived") return null;

return column;

const column = linkedTask?.column;

if (column === "triage" || column === "todo" || column === "in-progress" || column === "in-review") return column;

return null;

Copilot AI review requested due to automatic review settings July 5, 2026 16:54

Copilot AI reviewed Jul 5, 2026

greptile-apps Bot reviewed Jul 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(engine): defer validator fail to inconclusive while the linked task is unmerged#1917

fix(engine): defer validator fail to inconclusive while the linked task is unmerged#1917
flexi767 wants to merge 1 commit into
Runfusion:mainfrom
flexi767:fix/validator-premerge-guard

flexi767 commented Jul 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai Bot commented Jul 5, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

greptile-apps Bot commented Jul 5, 2026

Uh oh!

greptile-apps Bot Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

flexi767 commented Jul 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Tests

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

greptile-apps Bot commented Jul 5, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Flowchart

Uh oh!

greptile-apps Bot Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

flexi767 commented Jul 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 5, 2026 •

edited

Loading